From 1ccc3392c7467a7d9045e9f6945c260fd0e855df Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Sat, 28 Sep 2024 21:09:06 +0100 Subject: [PATCH 01/17] change racking_model default to none, formatting --- pvlib/pvsystem.py | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index 57752dff7e..7042f3a65e 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -17,7 +17,7 @@ from abc import ABC, abstractmethod from typing import Optional, Union -from pvlib._deprecation import deprecated, warn_deprecated +from pvlib._deprecation import deprecated import pvlib # used to avoid albedo name collision in the Array class from pvlib import (atmosphere, iam, inverter, irradiance, @@ -104,7 +104,7 @@ class PVSystem: ---------- arrays : Array or iterable of Array, optional An Array or list of arrays that are part of the system. If not - specified a single array is created from the other parameters (e.g. + specified, a single array is created from the other parameters (e.g. `surface_tilt`, `surface_azimuth`). If specified as a list, the list must contain at least one Array; if length of arrays is 0 a ValueError is raised. If `arrays` is @@ -127,7 +127,7 @@ class PVSystem: (e.g. surface facing up = 0, surface facing horizon = 90) surface_azimuth: float or array-like, default 180 - Azimuth angle of the module surface. + Azimuth angle of the module surface in decimal degrees. North=0, East=90, South=180, West=270. albedo : float, optional @@ -142,19 +142,20 @@ class PVSystem: module : string, optional The model name of the modules. - May be used to look up the module_parameters dictionary + May be used to look up the ``module_parameters`` dictionary via some other method. - module_type : string, default 'glass_polymer' - Describes the module's construction. Valid strings are 'glass_polymer' - and 'glass_glass'. Used for cell and module temperature calculations. + module_type : string, default `glass_polymer` + Describes the module's construction. Valid strings are `glass_polymer` + and `glass_glass`. Used for cell and module temperature calculations. module_parameters : dict or Series, optional Module parameters as defined by the SAPM, CEC, or other. temperature_model_parameters : dict or Series, optional Temperature model parameters as required by one of the models in - pvlib.temperature (excluding poa_global, temp_air and wind_speed). + py:func:`pvlib.temperature` (excluding ``poa_global``, ``temp_air`` and + ``wind_speed``). modules_per_string: int or float, default 1 See system topology discussion above. @@ -170,8 +171,9 @@ class PVSystem: inverter_parameters : dict or Series, optional Inverter parameters as defined by the SAPM, CEC, or other. - racking_model : string, default 'open_rack' - Valid strings are 'open_rack', 'close_mount', and 'insulated_back'. + racking_model : string, default None + Valid strings are ``open_rack``, ``close_mount``, and + ``insulated_back``. Used to identify a parameter set for the SAPM cell temperature model. losses_parameters : dict or Series, optional @@ -1373,7 +1375,7 @@ class FixedMount(AbstractMount): Azimuth angle of the module surface. North=0, East=90, South=180, West=270. [degrees] - racking_model : str, optional + racking_model : str, optional, default None Valid strings are 'open_rack', 'close_mount', and 'insulated_back'. Used to identify a parameter set for the SAPM cell temperature model. @@ -1450,7 +1452,7 @@ class SingleAxisTrackerMount(AbstractMount): :func:`~pvlib.tracking.calc_cross_axis_tilt` to calculate `cross_axis_tilt`. [degrees] - racking_model : str, optional + racking_model : str, optional, default None Valid strings are 'open_rack', 'close_mount', and 'insulated_back'. Used to identify a parameter set for the SAPM cell temperature model. From 19afcf286bc12a5b4ddea1229cb0d89ba783e992 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Sat, 28 Sep 2024 21:37:18 +0100 Subject: [PATCH 02/17] Update pvsystem.py --- pvlib/pvsystem.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index 7042f3a65e..583b362342 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -165,16 +165,16 @@ class PVSystem: inverter : string, optional The model name of the inverters. - May be used to look up the inverter_parameters dictionary + May be used to look up the ``inverter_parameters`` dictionary via some other method. inverter_parameters : dict or Series, optional Inverter parameters as defined by the SAPM, CEC, or other. racking_model : string, default None - Valid strings are ``open_rack``, ``close_mount``, and - ``insulated_back``. - Used to identify a parameter set for the SAPM cell temperature model. + Valid strings are `open_rack`, `close_mount`, `freestanding`, or + `insulated_back`. + Used to identify a parameter set for the cell temperature model. losses_parameters : dict or Series, optional Losses parameters as defined by PVWatts or other. @@ -1376,10 +1376,11 @@ class FixedMount(AbstractMount): West=270. [degrees] racking_model : str, optional, default None - Valid strings are 'open_rack', 'close_mount', and 'insulated_back'. - Used to identify a parameter set for the SAPM cell temperature model. + Valid strings are `open_rack', `close_mount`, `freestanding`, or + `insulated_back`. + Used to identify a parameter set for the cell temperature model. - module_height : float, optional + module_height : float, optional, default None The height above ground of the center of the module [m]. Used for the Fuentes cell temperature model. """ @@ -1452,7 +1453,7 @@ class SingleAxisTrackerMount(AbstractMount): :func:`~pvlib.tracking.calc_cross_axis_tilt` to calculate `cross_axis_tilt`. [degrees] - racking_model : str, optional, default None + racking_model : str, optional Valid strings are 'open_rack', 'close_mount', and 'insulated_back'. Used to identify a parameter set for the SAPM cell temperature model. From 6cdf500cca28c73dfc40708b0bd52613236a7a31 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Sat, 28 Sep 2024 22:05:09 +0100 Subject: [PATCH 03/17] Update pvsystem.py --- pvlib/pvsystem.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index 583b362342..7c205f944f 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -188,7 +188,7 @@ class PVSystem: Raises ------ ValueError - If `arrays` is not None and has length 0. + If ``arrays`` is not None and has length 0. See also -------- @@ -1376,7 +1376,7 @@ class FixedMount(AbstractMount): West=270. [degrees] racking_model : str, optional, default None - Valid strings are `open_rack', `close_mount`, `freestanding`, or + Valid strings are `open_rack`, `close_mount`, `freestanding`, or `insulated_back`. Used to identify a parameter set for the cell temperature model. From 35222dc237865ba7de8d522997d67f3cffe3789b Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Sun, 29 Sep 2024 18:05:44 +0100 Subject: [PATCH 04/17] Apply suggestions from code review Co-authored-by: Cliff Hansen --- pvlib/pvsystem.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index 7c205f944f..82f05b72b9 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -154,7 +154,7 @@ class PVSystem: temperature_model_parameters : dict or Series, optional Temperature model parameters as required by one of the models in - py:func:`pvlib.temperature` (excluding ``poa_global``, ``temp_air`` and + :py:mod:`pvlib.temperature` (excluding ``poa_global``, ``temp_air`` and ``wind_speed``). modules_per_string: int or float, default 1 From ab8cedebcf3e75aac715ade0f2df3b0b0efa7cd4 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Sun, 29 Sep 2024 18:08:09 +0100 Subject: [PATCH 05/17] review suggestions Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com> --- pvlib/pvsystem.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index 7c205f944f..70323e24d7 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -142,8 +142,6 @@ class PVSystem: module : string, optional The model name of the modules. - May be used to look up the ``module_parameters`` dictionary - via some other method. module_type : string, default `glass_polymer` Describes the module's construction. Valid strings are `glass_polymer` @@ -165,8 +163,6 @@ class PVSystem: inverter : string, optional The model name of the inverters. - May be used to look up the ``inverter_parameters`` dictionary - via some other method. inverter_parameters : dict or Series, optional Inverter parameters as defined by the SAPM, CEC, or other. From a8fc0b8bd3831eedff77ef0a0c88c03f6b84a5f5 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Mon, 30 Sep 2024 17:46:51 +0100 Subject: [PATCH 06/17] Update v0.11.2.rst --- docs/sphinx/source/whatsnew/v0.11.2.rst | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.11.2.rst b/docs/sphinx/source/whatsnew/v0.11.2.rst index 9d7129d50d..e3f75c2ad0 100644 --- a/docs/sphinx/source/whatsnew/v0.11.2.rst +++ b/docs/sphinx/source/whatsnew/v0.11.2.rst @@ -16,7 +16,11 @@ Documentation ~~~~~~~~~~~~~ * Edited docstrings for :py:func:`~pvlib.pvsystem.dc_ohms_from_percent` and :py:func:`~pvlib.pvsystem.dc_ohmic_loss` for clarity. (:issue:`1601`, :pull:`2229`) - +* Corrected the default values for module height and racking model to None in + the :py:class:`~pvlib.pvsystem.PVSystem` and + :py:class:`~pvlib.pvsystem.FixedMount` docstrings, added the freestanding + racking model option, and various formatting edits for clarity. + (:issue:`1942`, :pull:`2232`) Testing ~~~~~~~ @@ -29,4 +33,5 @@ Requirements Contributors ~~~~~~~~~~~~ * Cliff Hansen (:ghuser:`cwhanse`) +* Rajiv Daxini (:ghuser:`RDaxini`) From a9a26136a4309a2e40ab3610fd73402e8816c1dd Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Tue, 1 Oct 2024 18:21:31 +0100 Subject: [PATCH 07/17] Update pvlib/pvsystem.py Co-authored-by: Kevin Anderson --- pvlib/pvsystem.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index 103b319f01..2a3215e3a6 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -153,7 +153,7 @@ class PVSystem: temperature_model_parameters : dict or Series, optional Temperature model parameters as required by one of the models in :py:mod:`pvlib.temperature` (excluding ``poa_global``, ``temp_air`` and - ``wind_speed``). + ``wind_speed``). modules_per_string: int or float, default 1 See system topology discussion above. From 27db22c88ca82fa74639f2e2d3b577cc4500fc7f Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Tue, 1 Oct 2024 18:22:43 +0100 Subject: [PATCH 08/17] Update pvsystem.py --- pvlib/pvsystem.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index 103b319f01..658030fe92 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -167,7 +167,7 @@ class PVSystem: inverter_parameters : dict or Series, optional Inverter parameters as defined by the SAPM, CEC, or other. - racking_model : string, default None + racking_model : string, optional Valid strings are `open_rack`, `close_mount`, `freestanding`, or `insulated_back`. Used to identify a parameter set for the cell temperature model. @@ -1371,12 +1371,12 @@ class FixedMount(AbstractMount): Azimuth angle of the module surface. North=0, East=90, South=180, West=270. [degrees] - racking_model : str, optional, default None + racking_model : str, optional Valid strings are `open_rack`, `close_mount`, `freestanding`, or `insulated_back`. Used to identify a parameter set for the cell temperature model. - module_height : float, optional, default None + module_height : float, optional The height above ground of the center of the module [m]. Used for the Fuentes cell temperature model. """ From e1bc914687aef6c266e7f86a658a76ee1b84abaf Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Tue, 1 Oct 2024 20:39:14 +0100 Subject: [PATCH 09/17] backticks --- pvlib/pvsystem.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index 11d3021143..4aad5bcb47 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -143,9 +143,9 @@ class PVSystem: module : string, optional The model name of the modules. - module_type : string, default `glass_polymer` - Describes the module's construction. Valid strings are `glass_polymer` - and `glass_glass`. Used for cell and module temperature calculations. + module_type : string, default 'glass_polymer' + Describes the module's construction. Valid strings are 'glass_polymer' + and 'glass_glass'. Used for cell and module temperature calculations. module_parameters : dict or Series, optional Module parameters as defined by the SAPM, CEC, or other. @@ -168,8 +168,8 @@ class PVSystem: Inverter parameters as defined by the SAPM, CEC, or other. racking_model : string, optional - Valid strings are `open_rack`, `close_mount`, `freestanding`, or - `insulated_back`. + Valid strings are 'open_rack', 'close_mount', 'freestanding', or + 'insulated_back'. Used to identify a parameter set for the cell temperature model. losses_parameters : dict or Series, optional @@ -1372,8 +1372,8 @@ class FixedMount(AbstractMount): West=270. [degrees] racking_model : str, optional - Valid strings are `open_rack`, `close_mount`, `freestanding`, or - `insulated_back`. + Valid strings are 'open_rack', 'close_mount', 'freestanding', or + 'insulated_back'. Used to identify a parameter set for the cell temperature model. module_height : float, optional From 3d5548c9076610d3bf7d120c0d48b4d89b0fbf44 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Tue, 1 Oct 2024 20:58:06 +0100 Subject: [PATCH 10/17] Update pvsystem.py --- pvlib/pvsystem.py | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index 4aad5bcb47..f2b49c5506 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -110,16 +110,16 @@ class PVSystem: if length of arrays is 0 a ValueError is raised. If `arrays` is specified the following PVSystem parameters are ignored: - - `surface_tilt` - - `surface_azimuth` - - `albedo` - - `surface_type` - - `module` - - `module_type` - - `module_parameters` - - `temperature_model_parameters` - - `modules_per_string` - - `strings_per_inverter` + - ``surface_tilt`` + - ``surface_azimuth`` + - ``albedo`` + - ``surface_type`` + - ``module`` + - ``module_type`` + - ``module_parameters`` + - ``temperature_model_parameters`` + - ``modules_per_string`` + - ``strings_per_inverter`` surface_tilt: float or array-like, default 0 Surface tilt angles in decimal degrees. From 6429339f697583ec33018e079acbba45d4356451 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Sun, 20 Oct 2024 15:59:10 +0100 Subject: [PATCH 11/17] whatsnew remove blank line --- docs/sphinx/source/whatsnew/v0.11.2.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.11.2.rst b/docs/sphinx/source/whatsnew/v0.11.2.rst index 1f6664ed77..bfaac97d4f 100644 --- a/docs/sphinx/source/whatsnew/v0.11.2.rst +++ b/docs/sphinx/source/whatsnew/v0.11.2.rst @@ -43,7 +43,6 @@ Contributors ~~~~~~~~~~~~ * Cliff Hansen (:ghuser:`cwhanse`) * Rajiv Daxini (:ghuser:`RDaxini`) - * Mark Mikofski (:ghuser:`mikofski`) * matsuobasho (:ghuser:`matsuobasho`) * Echedey Luis (:ghuser:`echedey-ls`) From 1273ccbe159c4af0f018cf6464bc9b91c6f92a7d Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Tue, 12 Nov 2024 13:12:06 -0700 Subject: [PATCH 12/17] Apply suggestions from code review Co-authored-by: Kevin Anderson --- docs/sphinx/source/whatsnew/v0.11.2.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/sphinx/source/whatsnew/v0.11.2.rst b/docs/sphinx/source/whatsnew/v0.11.2.rst index bfaac97d4f..032b2a6a06 100644 --- a/docs/sphinx/source/whatsnew/v0.11.2.rst +++ b/docs/sphinx/source/whatsnew/v0.11.2.rst @@ -15,13 +15,12 @@ Enhancements Documentation ~~~~~~~~~~~~~ * Edited docstrings for :py:func:`~pvlib.pvsystem.dc_ohms_from_percent` and - :py:func:`~pvlib.pvsystem.dc_ohmic_loss` for clarity. (:issue:`1601`, :pull:`2229`) + :py:func:`~pvlib.pvsystem.dc_ohmic_losses` for clarity. (:issue:`1601`, :pull:`2229`) * Corrected the default values for module height and racking model to None in the :py:class:`~pvlib.pvsystem.PVSystem` and :py:class:`~pvlib.pvsystem.FixedMount` docstrings, added the freestanding racking model option, and various formatting edits for clarity. (:issue:`1942`, :pull:`2232`) - :py:func:`~pvlib.pvsystem.dc_ohmic_losses` for clarity. (:issue:`1601`, :pull:`2229`) * Updated :py:func:`~pvlib.irradiance.reindl` to include definitions of terms and a new "notes" section (:issue:`2183`, :pull:`2193`) From 5095d83f77be15ba7f5f08a0ee31e39867120029 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Tue, 12 Nov 2024 13:32:37 -0700 Subject: [PATCH 13/17] add `insulated` racking model option --- pvlib/pvsystem.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index f2b49c5506..5db06bad89 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -168,8 +168,8 @@ class PVSystem: Inverter parameters as defined by the SAPM, CEC, or other. racking_model : string, optional - Valid strings are 'open_rack', 'close_mount', 'freestanding', or - 'insulated_back'. + Valid strings are 'open_rack', 'close_mount', 'freestanding', + `insulated`, or 'insulated_back'. Used to identify a parameter set for the cell temperature model. losses_parameters : dict or Series, optional @@ -1372,8 +1372,8 @@ class FixedMount(AbstractMount): West=270. [degrees] racking_model : str, optional - Valid strings are 'open_rack', 'close_mount', 'freestanding', or - 'insulated_back'. + Valid strings are 'open_rack', 'close_mount', 'freestanding', + `insulated`, or 'insulated_back'. Used to identify a parameter set for the cell temperature model. module_height : float, optional From 5869a19162119de278ebfa672e45888043812480 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Tue, 12 Nov 2024 13:38:30 -0700 Subject: [PATCH 14/17] erroneous `` --- pvlib/pvsystem.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index 5db06bad89..a23c417e41 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -169,7 +169,7 @@ class PVSystem: racking_model : string, optional Valid strings are 'open_rack', 'close_mount', 'freestanding', - `insulated`, or 'insulated_back'. + 'insulated', or 'insulated_back'. Used to identify a parameter set for the cell temperature model. losses_parameters : dict or Series, optional @@ -1373,7 +1373,7 @@ class FixedMount(AbstractMount): racking_model : str, optional Valid strings are 'open_rack', 'close_mount', 'freestanding', - `insulated`, or 'insulated_back'. + 'insulated', or 'insulated_back'. Used to identify a parameter set for the cell temperature model. module_height : float, optional From 23bfd6899c4a0bfe398fbfef93853007bec91a97 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Tue, 12 Nov 2024 13:39:38 -0700 Subject: [PATCH 15/17] Update v0.11.2.rst --- docs/sphinx/source/whatsnew/v0.11.2.rst | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/docs/sphinx/source/whatsnew/v0.11.2.rst b/docs/sphinx/source/whatsnew/v0.11.2.rst index 032b2a6a06..59b9eb3234 100644 --- a/docs/sphinx/source/whatsnew/v0.11.2.rst +++ b/docs/sphinx/source/whatsnew/v0.11.2.rst @@ -16,11 +16,10 @@ Documentation ~~~~~~~~~~~~~ * Edited docstrings for :py:func:`~pvlib.pvsystem.dc_ohms_from_percent` and :py:func:`~pvlib.pvsystem.dc_ohmic_losses` for clarity. (:issue:`1601`, :pull:`2229`) -* Corrected the default values for module height and racking model to None in - the :py:class:`~pvlib.pvsystem.PVSystem` and - :py:class:`~pvlib.pvsystem.FixedMount` docstrings, added the freestanding - racking model option, and various formatting edits for clarity. - (:issue:`1942`, :pull:`2232`) +* Added 'freestanding' and 'insulated' `racking_model` options for cell + temperature calculation in :py:class:`~pvlib.pvsystem.PVSystem` and + :py:class:`~pvlib.pvsystem.FixedMount` docstrings. Various formatting edits + for clarity. (:issue:`1942`, :pull:`2232`) * Updated :py:func:`~pvlib.irradiance.reindl` to include definitions of terms and a new "notes" section (:issue:`2183`, :pull:`2193`) From 5702b97218e3dd3da4e8dd4a4cb9276a10c6d31c Mon Sep 17 00:00:00 2001 From: RDaxini Date: Fri, 15 Nov 2024 15:06:48 -0700 Subject: [PATCH 16/17] update SingleAxisTrackerMount --- pvlib/pvsystem.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index 648dc5392a..1fde69216c 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -1471,8 +1471,9 @@ class SingleAxisTrackerMount(AbstractMount): `cross_axis_tilt`. [degrees] racking_model : str, optional - Valid strings are 'open_rack', 'close_mount', and 'insulated_back'. - Used to identify a parameter set for the SAPM cell temperature model. + Valid strings are 'open_rack', 'close_mount', 'freestanding', + 'insulated', or 'insulated_back'. + Used to identify a parameter set for the cell temperature model. module_height : float, optional The height above ground of the center of the module [m]. Used for From da982c610eb2bac6682b3d1e189eab2223eb2955 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Fri, 15 Nov 2024 15:07:52 -0700 Subject: [PATCH 17/17] Update v0.11.2.rst --- docs/sphinx/source/whatsnew/v0.11.2.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.11.2.rst b/docs/sphinx/source/whatsnew/v0.11.2.rst index f6a203c359..32335b12ac 100644 --- a/docs/sphinx/source/whatsnew/v0.11.2.rst +++ b/docs/sphinx/source/whatsnew/v0.11.2.rst @@ -26,7 +26,8 @@ Documentation * Edited docstrings for :py:func:`~pvlib.pvsystem.dc_ohms_from_percent` and :py:func:`~pvlib.pvsystem.dc_ohmic_losses` for clarity. (:issue:`1601`, :pull:`2229`) * Added 'freestanding' and 'insulated' `racking_model` options for cell - temperature calculation in :py:class:`~pvlib.pvsystem.PVSystem` and + temperature calculation in :py:class:`~pvlib.pvsystem.PVSystem` + :py:class:`~pvlib.pvsystem.SingleAxisTrackerMount`, and :py:class:`~pvlib.pvsystem.FixedMount` docstrings. Various formatting edits for clarity. (:issue:`1942`, :pull:`2232`) * Added a new citation style guide (:ref:`references`) to the contributing