You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Docstring for pvsystem.sapm states
module : dict-like
A dict, Series, or DataFrame defining the SAPM performance
parameters. See the notes section for more details.
DataFrame input is not tested. The function errors when module parameter are supplied in a DataFrame.
To Reproduce
Steps to reproduce the behavior: see attached
Expected behavior pvsystem.sapm should give correct results if parameters are in a DataFrame. Otherwise, we should remove the option from the docstring.
Is there a compelling reason to support a DataFrame input? If not, let's remove the option. I'm ok continuing to support Series because that's what you get when you select a column from the module parameters DataFrame.
The only use case I can think of is to calculate output for several modules with the same irradiance and temperature condition. It would be convenient to generate a table of output at STC, for example. Important? I'm not convinced.
Uh oh!
There was an error while loading. Please reload this page.
Describe the bug
Docstring for
pvsystem.sapm
statesDataFrame input is not tested. The function errors when module parameter are supplied in a DataFrame.
To Reproduce
Steps to reproduce the behavior: see attached
Expected behavior
pvsystem.sapm
should give correct results if parameters are in a DataFrame. Otherwise, we should remove the option from the docstring.Versions:
pvlib.__version__
: 0.6.1pandas.__version__
: 0.24.2sapm_dataframe.txt
The text was updated successfully, but these errors were encountered: