Skip to content

Contributing #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmu opened this issue Apr 4, 2015 · 6 comments · Fixed by #135
Closed

Contributing #46

bmu opened this issue Apr 4, 2015 · 6 comments · Fixed by #135
Milestone

Comments

@bmu
Copy link
Contributor

bmu commented Apr 4, 2015

If we agree on it, we could either completely rely on pandas or give some rules, where we use our own conventions (in the wiki or in the docs).

@bmu bmu added this to the 0.2 milestone Apr 4, 2015
@wholmgren
Copy link
Member

Most of the stuff I wrote was inspired by pandas (maybe I should have made that more clear), but I felt that we should have something more than just "go look at pandas" since new contributors might not yet understand the scientific python ecosystem. I'm open to changing this, though.

@bmu
Copy link
Contributor Author

bmu commented Apr 6, 2015

Ok, I think this is a good approach. However we could provide the link to pandas, if we agree on all of the thinks that are stated there.

@wholmgren
Copy link
Member

I added a handful of links to the pandas pages. Feel free to edit anything.

@bmu bmu modified the milestones: 0.1, 0.2 Apr 6, 2015
@bmu
Copy link
Contributor Author

bmu commented Apr 6, 2015

Ok, thanks. I'll close this issue.

@bmu bmu closed this as completed Apr 6, 2015
@wholmgren
Copy link
Member

The new 0.16.1 pandas release has a new Contributing to pandas page. It's really good. I still think we should have a small wiki, but I'll add and emphasize links to this.

@wholmgren wholmgren reopened this May 11, 2015
@wholmgren wholmgren modified the milestones: 0.2, 0.1 May 11, 2015
@wholmgren
Copy link
Member

I renamed the Development information wiki to Contributing to pvlib python and rewrote some of the text. I hope we can get some other people to add-to/clarify the wiki in the future, so I'm going to leave this open for 0.3. I think @jforbess's perspective would be helpful here. I found it hard to strike a balance between high-level overview with links as opposed to detailed instructions.

@wholmgren wholmgren modified the milestones: 0.3, 0.2 Jun 21, 2015
@wholmgren wholmgren mentioned this issue Mar 15, 2016
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants