Skip to content

Change solar_zenith to apparent_zenith when angle is refraction corrected #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RDaxini opened this issue Apr 25, 2025 · 1 comment
Closed
Labels
api deprecation Use for issues and PRs which involve deprecations documentation
Milestone

Comments

@RDaxini
Copy link
Contributor

RDaxini commented Apr 25, 2025

Is your feature request related to a problem? Please describe.
The term solar_zenith is used for both refraction-corrected (apparent) zenith angles and non-refraction-corrected zenith angles. Example functions from irradiance.py: klucher, haydavies, reindl, king, perez, and perez_driesse. Also examples in infinite_sheds.py: _shaded_fraction, get_irradiance_poa, and get_irradiance.

Describe the solution you'd like
Replace solar_zenith with apparent_zenith for refraction-corrected solar zenith angles. Both terms already have nomenclature entries.

Additional context
Incorrect (example):

solar_zenith : numeric
Refraction-corrected solar zenith. [degree]

solar_zenith : numeric
Apparent (refraction-corrected) zenith angles in decimal
degrees. ``solar_zenith`` must be >=0 and <=180.

Correct (example):
apparent_zenith : numeric
Refraction corrected solar zenith angle in degrees.

@RDaxini RDaxini added this to the v0.12.1 milestone Apr 25, 2025
@RDaxini RDaxini added documentation api deprecation Use for issues and PRs which involve deprecations labels Apr 25, 2025
@RDaxini RDaxini changed the title Change solar_zenith to apparent_zenith whe nangle is refraction corrected Change solar_zenith to apparent_zenith when angle is refraction corrected Apr 25, 2025
@RDaxini RDaxini modified the milestones: v0.12.1, v0.13.0 Apr 25, 2025
@kandersolar
Copy link
Member

@RDaxini see #1403. Let's continue any discussion there for continuity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api deprecation Use for issues and PRs which involve deprecations documentation
Projects
None yet
Development

No branches or pull requests

2 participants