Skip to content

Clarify f_x #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cwhanse opened this issue Feb 27, 2023 · 2 comments · Fixed by #1727
Closed

Clarify f_x #1677

cwhanse opened this issue Feb 27, 2023 · 2 comments · Fixed by #1727

Comments

@cwhanse
Copy link
Member

cwhanse commented Feb 27, 2023

In some private functions of pvlib.bifacial.infinite_sheds, the parameter f_x is described as

    f_x : numeric
        Fraction of row slant height from the bottom that is shaded from
        direct irradiance.

In other public functions, the description is

    f_x : numeric
        Fraction of row slant height from the bottom that is shaded. [unitless]

For users trying to understand this algorithm, the different definitions can be confusing, because saying just "shaded" could mean shaded from diffuse irradiance by the adjacent row.

Describe the solution you'd like
Use the longer description for all instances of f_x.

@ayeankit
Copy link

hey @cwhanse , is this still open?

@cwhanse
Copy link
Member Author

cwhanse commented Mar 13, 2023

@ayeankit yes, it is open

@cwhanse cwhanse mentioned this issue May 4, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants