Skip to content

Commit c6e870c

Browse files
authored
set default module and inverter_parameters to empty dict (#304)
1 parent dd79085 commit c6e870c

File tree

3 files changed

+19
-2
lines changed

3 files changed

+19
-2
lines changed

docs/sphinx/source/whatsnew/v0.4.4.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,14 @@ Enhancements
1010
improvements by Ineichen and Perez to extend range of air mass (:issue:`278`)
1111

1212

13+
API Changes
14+
~~~~~~~~~~~
15+
16+
* Change PVSystem default module_parameters and inverter_parameters to
17+
empty dict. Code that relied on these attributes being None or raising
18+
a TypeError will need to be updated. (issue:`294`)
19+
20+
1321
Documentation
1422
~~~~~~~~~~~~~
1523

pvlib/pvsystem.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,19 @@ def __init__(self,
133133

134134
# could tie these together with @property
135135
self.module = module
136-
self.module_parameters = module_parameters
136+
if module_parameters is None:
137+
self.module_parameters = {}
138+
else:
139+
self.module_parameters = module_parameters
137140

138141
self.modules_per_string = modules_per_string
139142
self.strings_per_inverter = strings_per_inverter
140143

141144
self.inverter = inverter
142-
self.inverter_parameters = inverter_parameters
145+
if inverter_parameters is None:
146+
self.inverter_parameters = {}
147+
else:
148+
self.inverter_parameters = inverter_parameters
143149

144150
self.racking_model = racking_model
145151

pvlib/test/test_pvsystem.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -615,6 +615,9 @@ def test_snlinverter_Pnt_micro(sam_data):
615615

616616
def test_PVSystem_creation():
617617
pv_system = pvsystem.PVSystem(module='blah', inverter='blarg')
618+
# ensure that parameter attributes are dict-like. GH 294
619+
pv_system.module_parameters['pdc0'] = 1
620+
pv_system.inverter_parameters['Paco'] = 1
618621

619622

620623
def test_PVSystem_get_aoi():

0 commit comments

Comments
 (0)