Skip to content

Commit 537be43

Browse files
committed
more minor clean up
1 parent 71a4209 commit 537be43

File tree

1 file changed

+11
-19
lines changed

1 file changed

+11
-19
lines changed

pvlib/tmy.py

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -394,43 +394,35 @@ def readtmy2(filename):
394394
395395
[1] Marion, W and Urban, K. "Wilcox, S and Marion, W. "User's Manual
396396
for TMY2s". NREL 1995.
397-
398-
See also
399-
--------
400-
401-
pvl_makelocationstruct
402-
pvl_maketimestruct
403-
pvl_readtmy3
404-
405397
'''
406398

407399
if filename is None: #If no filename is input
408400
try:
409-
filename = interactive_load()
401+
filename = _interactive_load()
410402
except:
411403
raise Exception('Interactive load failed. Tkinter not supported on this system. Try installing X-Quartz and reloading')
412404

413-
string='%2d%2d%2d%2d%4d%4d%4d%1s%1d%4d%1s%1d%4d%1s%1d%4d%1s%1d%4d%1s%1d%4d%1s%1d%4d%1s%1d%2d%1s%1d%2d%1s%1d%4d%1s%1d%4d%1s%1d%3d%1s%1d%4d%1s%1d%3d%1s%1d%3d%1s%1d%4d%1s%1d%5d%1s%1d%10d%3d%1s%1d%3d%1s%1d%3d%1s%1d%2d%1s%1d'
414-
columns='year,month,day,hour,ETR,ETRN,GHI,GHISource,GHIUncertainty,DNI,DNISource,DNIUncertainty,DHI,DHISource,DHIUncertainty,GHillum,GHillumSource,GHillumUncertainty,DNillum,DNillumSource,DNillumUncertainty,DHillum,DHillumSource,DHillumUncertainty,Zenithlum,ZenithlumSource,ZenithlumUncertainty,TotCld,TotCldSource,TotCldUnertainty,OpqCld,OpqCldSource,OpqCldUncertainty,DryBulb,DryBulbSource,DryBulbUncertainty,DewPoint,DewPointSource,DewPointUncertainty,RHum,RHumSource,RHumUncertainty,Pressure,PressureSource,PressureUncertainty,Wdir,WdirSource,WdirUncertainty,Wspd,WspdSource,WspdUncertainty,Hvis,HvisSource,HvisUncertainty,CeilHgt,CeilHgtSource,CeilHgtUncertainty,PresentWeather,Pwat,PwatSource,PwatUncertainty,AOD,AODSource,AODUncertainty,SnowDepth,SnowDepthSource,SnowDepthUncertainty,LastSnowfall,LastSnowfallSource,LastSnowfallUncertaint'
415-
hdr_columns='WBAN,City,State,TZ,latitude,longitude,altitude'
405+
string = '%2d%2d%2d%2d%4d%4d%4d%1s%1d%4d%1s%1d%4d%1s%1d%4d%1s%1d%4d%1s%1d%4d%1s%1d%4d%1s%1d%2d%1s%1d%2d%1s%1d%4d%1s%1d%4d%1s%1d%3d%1s%1d%4d%1s%1d%3d%1s%1d%3d%1s%1d%4d%1s%1d%5d%1s%1d%10d%3d%1s%1d%3d%1s%1d%3d%1s%1d%2d%1s%1d'
406+
columns = 'year,month,day,hour,ETR,ETRN,GHI,GHISource,GHIUncertainty,DNI,DNISource,DNIUncertainty,DHI,DHISource,DHIUncertainty,GHillum,GHillumSource,GHillumUncertainty,DNillum,DNillumSource,DNillumUncertainty,DHillum,DHillumSource,DHillumUncertainty,Zenithlum,ZenithlumSource,ZenithlumUncertainty,TotCld,TotCldSource,TotCldUnertainty,OpqCld,OpqCldSource,OpqCldUncertainty,DryBulb,DryBulbSource,DryBulbUncertainty,DewPoint,DewPointSource,DewPointUncertainty,RHum,RHumSource,RHumUncertainty,Pressure,PressureSource,PressureUncertainty,Wdir,WdirSource,WdirUncertainty,Wspd,WspdSource,WspdUncertainty,Hvis,HvisSource,HvisUncertainty,CeilHgt,CeilHgtSource,CeilHgtUncertainty,PresentWeather,Pwat,PwatSource,PwatUncertainty,AOD,AODSource,AODUncertainty,SnowDepth,SnowDepthSource,SnowDepthUncertainty,LastSnowfall,LastSnowfallSource,LastSnowfallUncertaint'
407+
hdr_columns = 'WBAN,City,State,TZ,latitude,longitude,altitude'
416408

417-
TMY2, TMY2_meta = readTMY(string, columns, hdr_columns, filename)
409+
TMY2, TMY2_meta = _readTMY2(string, columns, hdr_columns, filename)
418410

419411
return TMY2, TMY2_meta
420412

421413

422414

423-
def parsemeta(columns,line):
415+
def _parsemeta_tmy2(columns, line):
424416
"""Retrieves metadata from the top line of the tmy2 file.
425417
426418
Parameters
427419
----------
428420
429-
Columns : string
430-
String of column headings in the header
421+
columns : string
422+
String of column headings in the header
431423
432424
line : string
433-
Header string containing DataFrame
425+
Header string containing DataFrame
434426
435427
Returns
436428
-------
@@ -454,15 +446,15 @@ def parsemeta(columns,line):
454446

455447

456448

457-
def readTMY(string, columns, hdr_columns, fname):
449+
def _readTMY2(string, columns, hdr_columns, fname):
458450
head=1
459451
date=[]
460452
with open(fname) as infile:
461453
fline=0
462454
for line in infile:
463455
#Skip the header
464456
if head!=0:
465-
meta=parsemeta(hdr_columns,line)
457+
meta = _parsemeta_tmy2(hdr_columns,line)
466458
head-=1
467459
continue
468460
#Reset the cursor and array for each line

0 commit comments

Comments
 (0)