Skip to content

Commit 8cb2ffb

Browse files
authored
Fix encode only replacing first occurrences (#254)
* Fix encode only replacing first occurrences
1 parent 948ec73 commit 8cb2ffb

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Breaking changes:
99
New features:
1010

1111
Bugfixes:
12+
- Fixed `encode` not replacing all instances of special characters (#254 by @jy14898)
1213

1314
## [v2021-08-25.1](https://github.com/purescript/trypurescript/releases/tag/v2021-08-25.1) - 2021-08-25
1415

staging/src/TryPureScript.purs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,18 @@ module TryPureScript
2020
import Prelude
2121
import Data.Foldable (class Foldable, foldMap)
2222
import Data.String (joinWith)
23-
import Data.String.Common (replace)
23+
import Data.String.Common (replaceAll)
2424
import Data.String.Pattern (Pattern(..), Replacement(..))
2525
import Effect (Effect)
2626

2727
foreign import setInnerHTML :: String -> Effect Unit
2828

2929
encode :: String -> String
3030
encode =
31-
replace (Pattern "<") (Replacement "&lt;")
32-
<<< replace (Pattern ">") (Replacement "&gt;")
33-
<<< replace (Pattern "&") (Replacement "&amp;")
34-
<<< replace (Pattern "\"") (Replacement "&quot;")
31+
replaceAll (Pattern "<") (Replacement "&lt;")
32+
<<< replaceAll (Pattern ">") (Replacement "&gt;")
33+
<<< replaceAll (Pattern "&") (Replacement "&amp;")
34+
<<< replaceAll (Pattern "\"") (Replacement "&quot;")
3535

3636
foreign import withConsoleImpl
3737
:: forall a

0 commit comments

Comments
 (0)