Add basic code point parsers #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdbrock
approved these changes
Mar 7, 2022
| Just chr -> pure chr | ||
| Nothing -> fail $ "Code point " <> show cp <> " is not a character" | ||
| where | ||
| toChar = fromCharCode <<< fromEnum |
Member
There was a problem hiding this comment.
Watch out for this bug in fromCharCode https://github.com/purescript-contrib/purescript-parsing/blob/33cbb663651f28062a2ffc0016033142b24bfed2/src/Text/Parsing/Parser/String.purs#L88-L90
Member
Author
There was a problem hiding this comment.
Fixed and uncommented the test I added for that earlier :)
| -- | Match any code point. | ||
| anyCodePoint :: Parser CodePoint | ||
| anyCodePoint = Parser \{ substring, position } -> | ||
| case SCP.codePointAt 0 substring of |
Member
There was a problem hiding this comment.
This looks fine but you could use uncons like so https://github.com/purescript-contrib/purescript-parsing/blob/33cbb663651f28062a2ffc0016033142b24bfed2/src/Text/Parsing/Parser/String.purs#L102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #85
Checklist: