(maint) Allow gettext-setup < 2 #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaggett
reviewed
Dec 6, 2022
Accept gettext-setup >= 1.1.0 for compatibility with fast-gettext 2.1 and Ruby 3.2. See puppetlabs/gettext-setup-gem@f4b292c
joshcooper
force-pushed
the
ruby32
branch
2 times, most recently
from
748f5b9 to
1bdc030
Compare
Contributor
Author
|
I can't add 3.2.0-rc1 to the github action because rugged doesn't support 3.2 yet (it still calls the removed method File.exists?) libgit2/rugged#943 |
Contributor
|
ahh okay. That is something we should keep track of - once we ship Ruby 3.2 with PE, sounds like we'll need to update the version of rugged that we vendor. |
mwaggett
approved these changes
Dec 8, 2022
Contributor
|
I opened https://tickets.puppetlabs.com/browse/PE-35010 to track the rugged update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept gettext-setup >= 1.1.0 for compatibility with fast-gettext 2.1 and Ruby 3.2.
See puppetlabs/gettext-setup-gem@f4b292c