(#MODULES-865) validate_re cannot match numeric regex in all cases #424
Conversation
The validate_re function now tries to convert it's first argument to a string. This will ensure that numeric, boolean, symbols, arrays and hashes can be matched by a regex since regex matching can only happen on strings. validate_re(1, '^\d+$') would previously fail because the first argument is a Fixnum. This patch ensures the first argument is cast to a string so this would match as one would expect.
|
Test seems to fail for arrays and hashes on puppet 2.7.x. So my fix does not work for Arrays and Hashes on 2.7.x (function reverts to it's old behavior) It does work for symbols, integers and floats however. Since I cannot test myslf on 2.7.x I would like some comments on how to proceed. Is this critical? |
|
I'm currently working on a major cleanup for the next major stdlib release. I'll see to it that this will be fixed there. |
|
The result of the test was: PASS I am a beta ci bot. I am probably lying to you. |
|
The result of the test was: PASS I am a beta ci bot. I am probably lying to you. |
|
Actually looking through the code, this change would break backwards compatibility in exactly the case where it's needed the most: when the input is unexpected. I've replaced this with #526, clarifying the docs and the error message. |
The validate_re function now tries to convert it's first argument to
a string. This will ensure that numeric, boolean, symbols, arrays and hashes can be matched
by a regex since regex matching can only happen on strings.
validate_re(1, '^\d+$') would previously fail because the first argument is a Fixnum.
This patch ensures the first argument is cast to a string so this would match as one would expect.