diff --git a/lib/puppet/parser/functions/uriescape.rb b/lib/puppet/parser/functions/uriescape.rb index b7de4c1e4..354ad2280 100644 --- a/lib/puppet/parser/functions/uriescape.rb +++ b/lib/puppet/parser/functions/uriescape.rb @@ -26,9 +26,9 @@ module Puppet::Parser::Functions result = if value.is_a?(Array) # Numbers in Puppet are often string-encoded which is troublesome ... - value.map { |i| i.is_a?(String) ? URI.escape(i) : i } + value.map { |i| i.is_a?(String) ? URI::DEFAULT_PARSER.escape(i) : i } else - URI.escape(value) + URI::DEFAULT_PARSER.escape(value) end return result diff --git a/spec/functions/uriescape_spec.rb b/spec/functions/uriescape_spec.rb index 3ac632ade..81b27c37d 100644 --- a/spec/functions/uriescape_spec.rb +++ b/spec/functions/uriescape_spec.rb @@ -16,16 +16,16 @@ end describe 'handling normal strings' do - it 'calls ruby\'s URI.escape function' do - expect(URI).to receive(:escape).with('uri_string').and_return('escaped_uri_string').once + it 'calls ruby\'s URI::DEFAULT_PARSER.escape function' do + expect(URI::DEFAULT_PARSER).to receive(:escape).with('uri_string').and_return('escaped_uri_string').once is_expected.to run.with_params('uri_string').and_return('escaped_uri_string') end end describe 'handling classes derived from String' do - it 'calls ruby\'s URI.escape function' do + it 'calls ruby\'s URI::DEFAULT_PARSER.escape function' do uri_string = AlsoString.new('uri_string') - expect(URI).to receive(:escape).with(uri_string).and_return('escaped_uri_string').once + expect(URI::DEFAULT_PARSER).to receive(:escape).with(uri_string).and_return('escaped_uri_string').once is_expected.to run.with_params(uri_string).and_return('escaped_uri_string') end end