Rework the tests to check actual values

Rather that testing that when called twice the function return the same
or different values, test the actual returned value so that we are sure
the behavior does not change unexpectedly.

Author: smortex

spec/functions/seeded_rand_spec.rb

@@ -17,44 +17,10 @@
   it { is_expected.to run.with_params(1, []).and_raise_error(ArgumentError, %r{second argument must be a string}) }
   it { is_expected.to run.with_params(1, {}).and_raise_error(ArgumentError, %r{second argument must be a string}) }
 
-  it 'provides a random number strictly less than the given max' do
-    expect(seeded_rand(3, 'seed')).to satisfy { |n| n.to_i < 3 } # rubocop:disable Lint/AmbiguousBlockAssociation : Cannot parenthesize without break code or violating other Rubocop rules
-  end
-
-  it 'provides a random number greater or equal to zero' do
-    expect(seeded_rand(3, 'seed')).to satisfy { |n| n.to_i >= 0 } # rubocop:disable Lint/AmbiguousBlockAssociation : Cannot parenthesize without break code or violating other Rubocop rules
-  end
-
-  it "provides the same 'random' value on subsequent calls for the same host" do
-    expect(seeded_rand(10, 'seed')).to eql(seeded_rand(10, 'seed'))
-  end
-
-  it 'allows seed to control the random value on a single host' do
-    first_random = seeded_rand(1000, 'seed1')
-    second_different_random = seeded_rand(1000, 'seed2')
-
-    expect(first_random).not_to eql(second_different_random)
-  end
-
-  it 'does not return different values for different hosts' do
-    val1 = seeded_rand(1000, 'foo', host: 'first.host.com')
-    val2 = seeded_rand(1000, 'foo', host: 'second.host.com')
-
-    expect(val1).to eql(val2)
-  end
-
-  def seeded_rand(max, seed, args = {})
-    host = args[:host] || '127.0.0.1'
-
-    # workaround not being able to use let(:facts) because some tests need
-    # multiple different hostnames in one context
-    allow(scope).to receive(:lookupvar).with('::fqdn', {}).and_return(host)
-
-    scope.function_seeded_rand([max, seed])
-  end
-
-  context 'with UTF8 and double byte characters' do
-    it { is_expected.to run.with_params(1000, 'ǿňè') }
-    it { is_expected.to run.with_params(1000, '文字列') }
+  context "produce predictible and reproducible results" do
+    it { is_expected.to run.with_params(20, 'foo').and_return(1) }
+    it { is_expected.to run.with_params(100, 'bar').and_return(35) }
+    it { is_expected.to run.with_params(1000, 'ǿňè').and_return(247) }
+    it { is_expected.to run.with_params(1000, '文字列').and_return(67) }
   end
 end