Merge pull request #1163 from pmcmaw/test_emails

DavidS · web-flow · commit 3373a08c2566 · 2021-02-10T13:22:45.000Z
(bugfix) Setting stricter email validation
diff --git a/spec/type_aliases/email_spec.rb b/spec/type_aliases/email_spec.rb
@@ -56,6 +56,9 @@
      'email@example.com (Joe Smith)',
      'email@-example.com',
      'email@example..com',
+     'random stuff multiline
+     valid@email.com
+     more random stuff $^*!',
      '”(),:;<>[\]@example.com',
      'just”not”right@example.com',
      'this\ is"really"not\allowed@example.com'].each do |value|
diff --git a/types/email.pp b/types/email.pp
@@ -1,2 +1,2 @@
 # https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address
-type Stdlib::Email = Pattern[/^[a-zA-Z0-9.!#$%&'*+\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$/]
+type Stdlib::Email = Pattern[/\A[a-zA-Z0-9.!#$%&'*+\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*\z/]

-Original file line number
+Diff line change
      '[email protected] (Joe Smith)',
      '[email protected]',
      '[email protected]',
 +     'random stuff multiline
 +     [email protected]
 +     more random stuff $^*!',
      '”(),:;<>[\]@example.com',
      'just”not”[email protected]',
      'this\ is"really"not\[email protected]'].each do |value|
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`# https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address`
`2`		-type Stdlib::Email = Pattern[/^[a-zA-Z0-9.!#$%&'+\/=?^_`{\|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)$/]
	`2`	+type Stdlib::Email = Pattern[/\A[a-zA-Z0-9.!#$%&'+\/=?^_`{\|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)\z/]