Merge pull request #798 from eputnam/round_func

(maint) move/rewrite round() as ruby function

Author: tphoney

README.md

@@ -1550,7 +1550,7 @@ For example, `reject(['aaa','bbb','ccc','aaaddd'], 'aaa')` returns ['bbb','ccc']
 
 Reverses the order of a string or array.
 
-#### `stdlib::round`
+#### `round`
 
  Rounds a number to the nearest integer
 

functions/round.pp

@@ -0,0 +1,33 @@
+#
+# round.rb
+#
+
+module Puppet::Parser::Functions
+  newfunction(:round, :type => :rvalue, :doc => <<-EOS
+  Rounds a number to the nearest integer
+
+  *Examples:*
+
+  round(2.9)
+
+  returns: 3
+
+  round(2.4)
+
+  returns: 2
+
+  EOS
+  ) do |args|
+
+    raise Puppet::ParseError, "round(): Wrong number of arguments given #{args.size} for 1" if args.size != 1
+    raise Puppet::ParseError, "round(): Expected a Numeric, got #{args[0].class}" unless args[0].is_a? Numeric
+
+    value = args[0]
+
+    if value >= 0
+      Integer(value + 0.5)
+    else
+      Integer(value - 0.5)
+    end
+  end
+end

lib/puppet/parser/functions/round.rb

@@ -1,11 +1,14 @@
 require 'spec_helper'
 
-describe 'stdlib::round' do
+describe 'round' do
   it { is_expected.not_to eq(nil) }
   it { is_expected.to run.with_params(34.3).and_return(34) }
   it { is_expected.to run.with_params(-34.3).and_return(-34) }
   it { is_expected.to run.with_params(34.5).and_return(35) }
   it { is_expected.to run.with_params(-34.5).and_return(-35) }
   it { is_expected.to run.with_params(34.7).and_return(35) }
   it { is_expected.to run.with_params(-34.7).and_return(-35) }
+  it { is_expected.to run.with_params("test").and_raise_error Puppet::ParseError }
+  it { is_expected.to run.with_params("test", "best").and_raise_error Puppet::ParseError }
+  it { is_expected.to run.with_params(3, 4).and_raise_error Puppet::ParseError }
 end