(FM-2577) - Change from sqlcmd.exe to win32ole connector #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cyberious
commented
Apr 29, 2015
cyberious
commented
- remove dependency to sqlcmd.exe and temp files, gives us more control and ability to get error messages back
- Login contains GO in sql query which breaks with new method
- Removes GO and adds the TRY and CATCH used throughout
- Login contains GO in sql query which breaks with new method
- Move config to $::vardir/cache/sqlserver instead of in C:/Program Files/Microsoft SQL Server/.puppet
add geppetto-rc file to ignore examples
This project is closed source and does not accept contributions.
FM-2122: Deleted irrelevant contribution information
Fix metadata.json and capture back puppet module build metadata.json
FM-2102 fix examples/sp_configure.pp
…ng usage on new expected behavior
FM-2110 Prep TSQL provider ...
FM-2110 README Predocs for sqlserver_tsql provider
Fix bug with TSQL provider rework
DOC-1510: edit tsql additions
FM-1900 Add User defined type
…or handling add for tsql
FM1901 Add delete user capabilities
FM-1898 Add sqlserver::user::permssion with GRANT, REVOKE and DENY
Update sqlserver_validate_range to take array
… of single permission
* cyberious/FM-2236: FM-2236 Change to permissions and allow user to pass an array instead of single permission FM-2236 Add with_grant_option for user permission
* cyberious/FM-1556: FM-1556 Change permission to permissions and allow for array FM-1556 Add ability to manage login server level permissions
FM-2303 Add install switches to sqlserver_install and sqlserver_features
FM-2287 Add Role Permissions ability
FM-2288 Role members
…ssions in one define
FM-2298 and FM-2299 update Login and User to take hash of permissions
puppetdb, etc - support for BEAKER_VERSION and BEAKER_RSPEC_VERSION in gemfile
(BKR-147) add Gemfile setting for BEAKER_VERSION for puppet...
Conflicts: spec/defines/manifest_shared_examples.rb
- Errant refactor resulted in @login_type variable not being used when it should have been - IS_SRVROLEMEMBER is no longer being used, since it's error reporting is not sufficient for our use case. When Active Directory cannot be accessed, and the username cannot be resolved, an error is not reported. Conflicts: templates/query/login_exists.sql.erb
…er_features" This reverts commit 9983ce2.
Conflicts: CHANGELOG.md metadata.json
Conflicts: README.md
* release: (24 commits) (FM-2110) sqlserver_tsql docs FM-2122: Added new PE-only development paragraph to readme Fix metadata.json and capture back puppet module build metadata.json (BKR-147) add Gemfile setting for BEAKER_VERSION for puppet... (maint) Adjust Geppetto rules (FM-2094) Fix examples to use sqlserver (maint) - Add .geppetto-rc.json to configure excludes Don't quote install switches true, false, 0, 1 (maint) Redefine installer switch definitions (maint) Add ACL module to fixtures dependency (maint) Add PE version requirement 3.7.x < 4.0.0 (maint) Refactor command line switch parsing (FM-2576) Add /ASSYSADMINACCOUNTS installer support (FM-2576) Whitelist parameters installer accepts (FM-2575) - Fixed bug with login exists, and creation Fix spec tests raise_error check (FM-2404) Refactor acceptance specs to not use shared context Add acceptance test starting framework, YAY ACCEPTANCE TESTS DOCS: Improved example for install_switches param FM-2328: document install_switches param in sqlserver ... Paired-with: Travis Fields <[email protected]>
- remove dependency to sqlcmd.exe and temp files, gives us more control and ability to get error messages back - Login contains GO in sql query which breaks with new method - Removes GO and adds the TRY and CATCH used throughout - Login contains GO in sql query which breaks with new method - Move config to $::vardir/cache/sqlserver instead of in C:/Program Files/Microsoft SQL Server/.puppet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.