(FM-3940) Puppet 4.3.0 missing param validation fix

The commit that added the empty parameter check to the compiler was released in
4.3.0 - puppetlabs/puppet@8c4a634

Specifically https://github.com/puppetlabs/puppet/blob/42681420d93b984ca06073494bc1b4d70acf4e5e/lib/puppet/pops/types/type_mismatch_describer.rb#L150-L154
is where the check is at. This overrides the check at https://github.com/puppetlabs/puppet/blob/42681420d93b984ca06073494bc1b4d70acf4e5e/lib/puppet/resource.rb#L480
where it passes the previous error message (the puppet sha is latest stable as of this commit).

Further constrain the specs to switch at version 4.3.0.

Author: ferventcoder

spec/defines/config_spec.rb

@@ -24,7 +24,7 @@
       :admin_user => 'sa',
     } }
 
-    if Puppet.version < '4.0.0'
+    if Puppet.version < '4.3.0'
       let(:error_message) { /Must pass admin_pass to Sqlserver::Config/ }
     else
       let(:error_message) { /expects a value for parameter 'admin_pass'/ }
@@ -43,7 +43,7 @@
     } }
 
 
-    if Puppet.version < '4.0.0'
+    if Puppet.version < '4.3.0'
       let(:error_message) { /Must pass admin_user to Sqlserver::Config/ }
     else
       let(:error_message) { /expects a value for parameter 'admin_user'/ }

spec/defines/login/permissions_spec.rb

@@ -14,7 +14,7 @@
       } }
       let(:raise_error_check) { 'Login must be between 1 and 128 characters' }
       describe 'missing' do
-        if Puppet.version < '4.0.0'
+        if Puppet.version < '4.3.0'
           let(:raise_error_check) { 'Must pass login to Sqlserver::Login::Permissions[myTitle]' }
         else
           let(:raise_error_check) { "expects a value for parameter 'login'" }

spec/defines/user/permissions_spec.rb

@@ -15,7 +15,7 @@
       } }
       let(:raise_error_check) { 'User must be between 1 and 128 characters' }
       describe 'missing' do
-        if Puppet.version < '4.0.0'
+        if Puppet.version < '4.3.0'
           let(:raise_error_check) { 'Must pass user to Sqlserver::User::Permissions[myTitle]' }
         else
           let(:raise_error_check) { "expects a value for parameter 'user'" }