Found a bug in the way we added parameters to the command line, if any metaparameters were used we added them as well which causes install to fail

Author: Travis Fields

lib/puppet/provider/sqlserver_instance/mssql.rb

@@ -110,8 +110,10 @@ def basic_cmd_args(features, action)
   def build_cmd_args(features, action="install")
     cmd_args = basic_cmd_args(features, action)
     if action == 'install'
-      (@resource.parameters.keys - %w(ensure loglevel features name provider source sql_sysadmin_accounts sql_security_mode install_switches).map(&:to_sym)).sort.collect do |key|
-        cmd_args << "/#{key.to_s.gsub(/_/, '').upcase}=\"#{@resource[key]}\""
+      %w(pid sa_pwd sql_svc_account sql_svc_password agt_svc_account agt_svc_password as_svc_account as_svc_password rs_svc_account rs_svc_password security_mode).map(&:to_sym).sort.collect do |key|
+        if not_nil_and_not_empty? @resource[key]
+          cmd_args << "/#{key.to_s.gsub(/_/, '').upcase}=\"#{@resource[key]}\""
+        end
       end
       if not_nil_and_not_empty? @resource[:sql_sysadmin_accounts]
         if @resource[:sql_sysadmin_accounts].kind_of?(Array)
@@ -120,6 +122,13 @@ def build_cmd_args(features, action="install")
           cmd_args << "/SQLSYSADMINACCOUNTS=\"#{@resource[:sql_sysadmin_accounts]}\""
         end
       end
+      if not_nil_and_not_empty? @resource[:as_sysadmin_accounts]
+        if @resource[:as_sysadmin_accounts].kind_of?(Array)
+          cmd_args << "/ASSYSADMINACCOUNTS=#{ Array.new(@resource[:as_sysadmin_accounts]).collect { |account| "\"#{account}\"" }.join(' ')}"
+        else
+          cmd_args << "/ASSYSADMINACCOUNTS=\"#{@resource[:as_sysadmin_accounts]}\""
+        end
+      end
     end
     cmd_args
   end