Skip to content

Commit 6334ef2

Browse files
committed
(maint) - test implementation
Have updated several test's throughout the codebase to use the new sensitive value for admin_user, admin_pass and password as proof of concept.
1 parent 3750d23 commit 6334ef2

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

spec/acceptance/sqlserver_config_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ def ensure_sqlserver_instance(inst_name, ensure_val = 'present')
4848
pp = <<-MANIFEST
4949
sqlserver::config{'#{inst_name}':
5050
instance_name => '#{inst_name}',
51-
admin_user => 'sa',
51+
admin_user => Sensitive('sa'),
5252
admin_pass => 'Pupp3t1@',
5353
}
5454
sqlserver::login{'#{@admin_user}':
5555
instance => '#{inst_name}',
5656
login_type => 'SQL_LOGIN',
5757
login => '#{@admin_user}',
58-
password => '#{@admin_pass}',
58+
password => Sensitive('#{@admin_pass}'),
5959
svrroles => {'sysadmin' => 1},
6060
}
6161
MANIFEST
@@ -65,8 +65,8 @@ def ensure_sqlserver_instance(inst_name, ensure_val = 'present')
6565
it 'Validate New Config WITH using instance_name in sqlserver::config' do
6666
pp = <<-MANIFEST
6767
sqlserver::config{'#{inst_name}':
68-
admin_user => '#{@admin_user}',
69-
admin_pass => '#{@admin_pass}',
68+
admin_user => Sensitive('#{@admin_user}'),
69+
admin_pass => Sensitive('#{@admin_pass}'),
7070
instance_name => '#{inst_name}',
7171
}
7272
sqlserver::database{'#{db_name}':

spec/acceptance/sqlserver_database_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ def run_sql_query_opts(query, expected_row_count)
2424
# delete created database:
2525
pp = <<-MANIFEST
2626
sqlserver::config{'MSSQLSERVER':
27-
admin_user => 'sa',
28-
admin_pass => 'Pupp3t1@',
27+
admin_user => Sensitive('sa'),
28+
admin_pass => Sensitive('Pupp3t1@'),
2929
}
3030
sqlserver::database{'#{@db_name}':
3131
ensure => 'absent',
@@ -40,8 +40,8 @@ def run_sql_query_opts(query, expected_row_count)
4040
it 'Test Case C89019: Create a database' do
4141
pp = <<-MANIFEST
4242
sqlserver::config{'MSSQLSERVER':
43-
admin_user => 'sa',
44-
admin_pass => 'Pupp3t1@',
43+
admin_user => Sensitive('sa'),
44+
admin_pass => Sensitive('Pupp3t1@'),
4545
}
4646
sqlserver::database{'#{@db_name}':
4747
}

spec/acceptance/sqlserver_login_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ def create_login_manifest(testcase, login_name, login_password, options = {})
8989
# Create a database, a simple table and windows accounts fixtures
9090
pp = <<-MANIFEST
9191
sqlserver::config{'MSSQLSERVER':
92-
admin_user => 'sa',
93-
admin_pass => 'Pupp3t1@',
92+
admin_user => Sensitive('sa'),
93+
admin_pass => Sensitive('Pupp3t1@'),
9494
}
9595
sqlserver::database{'#{db_name}':
9696
}
@@ -102,7 +102,7 @@ def create_login_manifest(testcase, login_name, login_password, options = {})
102102
}
103103
104104
user {'#{@windows_user}':
105-
password => '#{@login_passwd}',
105+
password => Sensitive('#{@login_passwd}'),
106106
ensure => 'present',
107107
}
108108
group {'#{@windows_group}':

0 commit comments

Comments
 (0)