(MAINT) Remove extraneous logic from spec

This commit removes logic from the features file in the acceptance
tests suite which existed only to support Puppet 3. This logic is
no longer needed as Puppet 3 is no longer supported. Additionally,
the way the logic was written caused the tests designed for Puppet
3 to run against Puppet 5.

This commit simplifies the maintenance and execution of the suite
of acceptance tests.

Author: michaeltlombardi

spec/acceptance/z_last_sqlserver_features_spec.rb

@@ -204,17 +204,8 @@ def bind_and_apply_failing_manifest(features, ensure_val = 'present')
 
       before(:all) do
         puppet_version = (on host, puppet('--version')).stdout.chomp
-
-        if puppet_version =~ /^4\.\d+\.\d+/
-          json_result = JSON.parse((on host, puppet('facts --render-as json')).raw_output)["values"]["sqlserver_instances"]
-          names = json_result.collect { |k, v| json_result[k].keys }.flatten
-        else
-          # use agents fact to get instance names
-          distmoduledir = on(host, "echo #{host['distmoduledir']}").raw_output.chomp
-          facter_opts = {:environment => {'FACTERLIB' => "#{distmoduledir}/sqlserver/lib/facter"}}
-
-          names = eval(fact_on(host, 'sqlserver_instances', facter_opts)).values.inject(:merge).keys
-        end
+        json_result = JSON.parse((on host, puppet('facts --render-as json')).raw_output)["values"]["sqlserver_instances"]
+        names = json_result.collect { |k, v| json_result[k].keys }.flatten
         remove_sql_instances(host, {:version => sql_version, :instance_names => names})
       end