Skip to content

Commit 47754c1

Browse files
committed
(maint) Update rakefile for puppetlabs_spec_helper
The rakefile is attempting to override the default puppet lint settings however these settings are more permissive than the defaults and are causing false lint failures e.g. the vendor directory is not excluded in thie Rakefile but the puppetlabs_spec_helper does this by default. This commit removes the ignore_paths setting as the spec helper already does this. Also added a comment that the 80 and 140 char rule changes can be removed once next version of spec_helper is released as they are already the defaults.
1 parent 54a3c0a commit 47754c1

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Rakefile

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
require 'puppetlabs_spec_helper/rake_tasks'
22
require 'puppet-lint/tasks/puppet-lint'
33

4+
# These lint exclusions are in puppetlabs_spec_helper but needs a version above 0.10.3
45
# Line length test is 80 chars in puppet-lint 1.1.0
56
PuppetLint.configuration.send('disable_80chars')
67
# Line length test is 140 chars in puppet-lint 2.x
78
PuppetLint.configuration.send('disable_140chars')
8-
PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", "pkg/**/*.pp"]
9+
910

1011
desc "Validate manifests, templates, and ruby files"
1112
task :validate do

0 commit comments

Comments
 (0)