(MAINT) add support for 2019 to test helpers

Author: Erick Banks

spec/acceptance/sqlserver_role_spec.rb

@@ -178,7 +178,6 @@ def ensure_sqlserver_logins_users(db_name)
         type        => 'DATABASE',
       }
       MANIFEST
-      require 'pry'; binding.pry;
       execute_manifest(pp, opts = {}) do |r|
         expect(r.stderr).not_to match(/Error/i)
       end

spec/spec_helper_acceptance.rb

@@ -11,7 +11,7 @@
 WIN_ISO_ROOT = "https://artifactory.delivery.puppetlabs.net/artifactory/generic__iso/iso/windows"
 WIN_2012R2_ISO = "en_windows_server_2012_r2_with_update_x64_dvd_6052708.iso"
 QA_RESOURCE_ROOT = "https://artifactory.delivery.puppetlabs.net/artifactory/generic__iso/iso/SQLServer"
-SQL_2019_ISO = "SQLServer-2019-CTP2-x64-ENU.iso"
+SQL_2019_ISO = "SQLServer2019CTP2.4-x64-ENU.iso"
 SQL_2016_ISO = "en_sql_server_2016_enterprise_with_service_pack_1_x64_dvd_9542382.iso"
 SQL_2014_ISO = "SQLServer2014SP3-FullSlipstream-x64-ENU.iso"
 SQL_2012_ISO = "SQLServer2012SP1-FullSlipstream-ENU-x64.iso"

spec/sql_testing_helpers.rb

@@ -56,6 +56,7 @@ def run_sql_query(host, opts = {}, &block)
       $Env:Path +=\";C:\\Program Files\\Microsoft SQL Server\\Client SDK\\ODBC\\110\\Tools\\Binn;C:\\Program Files\\Microsoft SQL Server\\110\\Tools\\Binn\\"
       $Env:Path +=\";C:\\Program Files\\Microsoft SQL Server\\Client SDK\\ODBC\\120\\Tools\\Binn;C:\\Program Files\\Microsoft SQL Server\\120\\Tools\\Binn\\"
       $Env:Path +=\";C:\\Program Files\\Microsoft SQL Server\\Client SDK\\ODBC\\130\\Tools\\Binn;C:\\Program Files\\Microsoft SQL Server\\130\\Tools\\Binn\\"
+      $Env:Path +=\";C:\\Program Files\\Microsoft SQL Server\\Client SDK\\ODBC\\150\\Tools\\Binn;C:\\Program Files\\Microsoft SQL Server\\150\\Tools\\Binn\\"
       sqlcmd.exe -S #{server}\\#{instance} -U #{sql_admin_user} -P #{sql_admin_pass} -Q \"#{query}\"
   EOS
   # sqlcmd has problem authenticate to sqlserver if the instance is the default one MSSQLSERVER
@@ -103,6 +104,12 @@ def base_install(sql_version)
       :file         => SQL_2016_ISO,
       :drive_letter => 'H'
     }
+  when 2019
+    iso_opts = {
+      :folder       => QA_RESOURCE_ROOT,
+      :file         => SQL_2019_ISO,
+      :drive_letter => 'H'
+    }
   end
   host = find_only_one('sql_host')
   # Mount the ISO on the agent
@@ -146,7 +153,7 @@ def remove_sql_instances(host, opts = {})
 end
 
 def get_install_paths(version)
-  vers = { '2012' => '110', '2014' => '120', '2016' => '130' }
+  vers = { '2012' => '110', '2014' => '120', '2016' => '130', '2019' => '150' }
 
   raise 'Valid version must be specified' if ! vers.keys.include?(version)