(PA-6393) Let '' (empty string) be an acceptable networking dhcp fact for all fedora versions #2711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
reviewed
May 6, 2024
… for all fedora versions - Fedora is susceptible to a bug in NetworkManager that causes it to fail networking_facts acceptance test. - This commit makes '' the acceptable value for networking dhcp fact in Fedora, so CI passes the test. - Since all Fedora versions seem to be having the issue, its been made generic to all versions in this commit. - See puppetlabs#2515
shubhamshinde360
changed the title
mhashizume
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.