User email display

[StanFromIreland]

Should the bot publish user emails like so:

A lot of people use a personal email for gh and send commits with a gh email. The bot seems to comment these without this consideration. From what I know it is generally not possible to get a users email.

This should probably be changed to comment the gh username?

[hugovk]

Should the bot publish user emails like so:

That's the same email used in the commit: https://github.com/python/cpython/pull/132587.patch (append .patch to the PR) so nothing private is disclosed in this instance.

I've not checked the code closely but I think it's only getting emails from commits?

Or are there cases where an author committed with a @users.noreply.github.com address, but the bot posted their otherwise private email address?

This should probably be changed to comment the gh username?

It's possible for a GitHub account to not contain the commit email. If we showed the GitHub username instead, they might think they have signed the CLA but in fact the commit email has not, and we'd go around in a few circles until we figured out the discrepancy.

[ewdurbin]

We probably don't absolutely need to show the email address anymore even if it is ostensibly public already, since the logged in dashboard shows you all email addresses awaiting signature. This was just written to match the behavior of the old bot.

One approach would be to improve what is displayed once signed in to show the repository name(s) that have ref's awaiting signature for each email.