Skip to content

FE: Logout button is not fully functional #4016 #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
corazoncoding wants to merge 2 commits into from
Closed

FE: Logout button is not fully functional #4016 #4031

corazoncoding wants to merge 2 commits into from

Conversation

@corazoncoding
Copy link

@corazoncoding corazoncoding commented Jul 12, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixed #4016
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@corazoncoding corazoncoding added type/bug Something isn't working scope/frontend labels Jul 12, 2023
@corazoncoding corazoncoding requested a review from a team as a code owner July 12, 2023 10:06
@corazoncoding corazoncoding self-assigned this Jul 12, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

Haarolean
Haarolean suggested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logout button doesn't work anymore at all, the redirect is now made within react app and redirects right into 404.

@Haarolean
Copy link
Contributor

Haarolean commented Jul 18, 2023

#4045

@Haarolean Haarolean closed this Jul 18, 2023
@Haarolean Haarolean deleted the issues/4016 branch July 18, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mgrdich Mgrdich Awaiting requested review from Mgrdich

1 more reviewer

@Haarolean Haarolean Haarolean requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@corazoncoding corazoncoding

Labels

scope/frontend type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FE: Logout button link is bound to a wrong div

3 participants

@corazoncoding @Haarolean