-
Notifications
You must be signed in to change notification settings - Fork 104
feat(metrics): support Gauge<u32, AtomicU32> type
#191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): support Gauge<u32, AtomicU32> type
#191
Conversation
Signed-off-by: koushiro <[email protected]>
|
@mxinden PTAL |
mxinden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Thanks. Looks good to me.
Can you bump the crate version in the root's Cargo.toml to v0.22.2 and add a CHANGELOG.md entry? Once this pull request merged, I can then cut a new release right away.
Signed-off-by: koushiro <[email protected]>
|
The following test: #[test]
fn encode_gauge() {
let mut registry = Registry::default();
let gauge = Gauge::<u32, AtomicU32>::default();
registry.register("my_gauge", "My gauge", gauge);
let mut encoded = String::new();
encode(&mut encoded, ®istry).unwrap();
parse_with_python_client(encoded);
}Would fail with: Mind adding an implementation of Please also extend the Sorry for the additional work. Thank you for the help. |
Signed-off-by: koushiro <[email protected]>
|
Thanks for your review, I have changed encoding related stuff and added a simple test case to |
Gauge<u32, AtomicU32> type
mxinden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
support
Gauge<u32, AtomicU32>metric