Refactor ocm connection

[VanillaSpoon]

Issue link

closes #115

What changes have been made

This pr includes a refactor of machinepools.go separating the logic to create an ocm connection. Improving readability :)

The pr also include minor refactors of appwrapper_controller.go reducing nested if/else statements.

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[anishasthana]

/lgtm

Is there an image that you've deployed somewhere that I can see in action?

[VanillaSpoon]

Hey Anish,
Thanks for the review, feel free to use this image: quay.io/rh_ee_egallina/instascale:OCMConnection

[asm582]

@VanillaSpoon Thanks for the PR, did you manually test these changes?

[VanillaSpoon]

Hey @asm582 ,
Yes, I have tested the changes manually on my side :)

[asm582]

Thanks @VanillaSpoon If you are doing manual tests, request that we add logs or log snippet to the PR going forward

[asm582]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [asm582]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[anishasthana]

/lgtm