adding korean sketch, prep for korean launch #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limzykenneth
reviewed
Aug 9, 2020
Co-authored-by: Kenneth Lim <[email protected]>
Contributor
|
hey! just want to make sure we're all good here in light of processing/p5.js-website#840 for this? @yukienomiya and I converted the korean translation file format and updated the rendering of the new format in the website back in processing/p5.js-website#836, so just want to make sure you've not seen anything unexpected afterwards! |
Member
Author
|
i think it looks ok but can you take a quick look if any of you have time? ❤️🙏 i’m on vaca this week with no computer. but we’re aiming to go live with korean today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes all the changes for the Korean launch happening on 8/14.