middleware not running in production

[chrisdrackett]

We've added a couple bits of middleware to our app. One for logging requests and one for capturing errors and sending them to sentry. Both of these work in development without issue, but as far as we can tell both are not running in production. Here is an example:

middleware/index.ts

import { schema, log } from 'nexus'

schema.middleware((config) => {
  return async (root, args, ctx, info, next) => {
    if (!root) {
      log.info('request', {
        type: config.parentTypeConfig.name,
        field: config.fieldConfig.name,
        args,
      })
    }

    return next(root, args, ctx, info)
  }
})

this is then just imported in app.ts

// import our middleware
import './middleware'

Are we doing something wrong here?

[chrisdrackett]

turns out if we move the above schema.middleware into our app.ts directly it works in production. I'm guessing that somehow on build it is getting ignored or removed? I wonder if there is a way to have nexus pay attention to a middleware folder in a similar way that it pays attention to the graphql folder?

[Weakky]

Hey @chrisdrackett, thanks for reporting that issue!

This is weird and I cannot reproduce locally. Importing your middleware file into the entrypoint is indeed the way to go here. I tried reproducing your setup and it works.

Could you maybe share a reproduction repo, or make sure you're using the latest nexus@next ?

[chrisdrackett]

@Weakky sure, here is a test app:

https://github.com/chrisdrackett/nexus-middleware-test

Locally I see 8971 ● app request -- type: 'Query' field: 'worlds' args: {} when making a request, after deploy to Heroku I see nothing when doing the same.

[Weakky]

Ah, I see. So this is not technically a bug, although it sucks. The reason why your middleware isn't working in dev nor prod is because your middleware/index.ts file export * from './test', but your middleware/test.ts file doesn't export anything. Therefore, middleware/index.ts does not require middleware/test.ts.

This problem should be gone once #833 is merged. In the meantime, you can solve that problem by replacing export * from './test' to import './test'

[chrisdrackett]

note that this does work in dev, just not production. Thanks for the info!

[Weakky]

Weird, I made the suggested change on your repro and it works even in the build output.

Are you maybe using different compiler options?

[chrisdrackett]

Sorry, the suggested change works for us! I was just noting that before the change things worked locally for us :)

[jasonkuhrt]

Was this issue related to

• Should be possible to force import of "unused" modules in case there are side-effects microsoft/TypeScript#9191

• importsNotUsedAsValues in https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-exports

• https://www.typescriptlang.org/docs/handbook/compiler-options.html

  Specify emit/checking behavior for imports that are only used for types. "remove" and "preserve" specify whether to emit unused imports for side effects, and "error" enforces that imports used only for types are written with import type.

🤔

[Corjen]

Hi @chrisdrackett, what does the middleware from Sentry look like? Can you share a snippet?

[chrisdrackett]

this is what we currently have:

errorMiddleware.ts

import { schema, log } from 'nexus'

import { Sentry } from '../sentry'

schema.middleware((config) => {
  return async (root, args, context, info, next) => {
    try {
      const result = await next(root, args, context, info)

      return result
    } catch (error) {
      Sentry.withScope((scope) => {
        scope.setExtra('type', config.parentTypeConfig.name)
        scope.setExtra('field', config.fieldConfig.name)
        scope.setExtra('args', args)
        scope.setExtra('headers', context.request.headers)
        scope.setTag('api-endpoint', `${process.env.API_ENDPOINT}`)
        Sentry.captureException(error)
      })

      log.error('error', { error })
    }
  }
})

sentry.ts

import * as Sentry from '@sentry/node'

// @ts-ignore
Sentry.init({
  dsn: 'dsn here',
  environment: process.env.APP_ENVIRONMENT,
  release: process.env.GIT_SHA,
  enabled: process.env.APP_ENVIRONMENT !== 'development',
})

export { Sentry }

[Corjen]

That’s quick😃 Thanks so much!