TreeView: Fix scroll behavior when focus changes #2464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ea16d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
colebemis
commented
Oct 20, 2022
joshblack
reviewed
Oct 21, 2022
| onKeyDown={handleKeyDown} | ||
| onFocus={event => { | ||
| // Scroll the first child into view when the item receives focus | ||
| event.currentTarget.firstElementChild?.scrollIntoView({block: 'nearest', inline: 'nearest'}) |
Member
There was a problem hiding this comment.
Ooo, love the firstElementChild usage ✨
joshblack
approved these changes
Oct 21, 2022
jdrush89
approved these changes
Oct 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handles the "scroll into view" behavior when focus moves between TreeView items.
Before
Notice how the scroll jumps when focus moves to a directory with lots of items:
CleanShot.2022-10-20.at.16.16.24.mp4
After
CleanShot.2022-10-20.at.16.10.44.mp4
Closes https://github.com/github/primer/issues/1432
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.