Skip to content

Avoid setting value for progress with nullish value #4492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2024
Merged

Avoid setting value for progress with nullish value #4492

merged 2 commits into from
Sep 13, 2024

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Sep 12, 2024 •
edited
Loading

Fixes #4487

I opted to add an alternative branch here which does a DOM-operation as special-casing progress/value in the setProperty would be a lot of work

@github-actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -1% - +0% (-10.13ms - +3.63ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.04ms - +0.07ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +1% (-0.64ms - +0.71ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +3% (-0.34ms - +0.53ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +2% (-1.72ms - +1.85ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.10ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.28ms - +0.19ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +4% (-0.78ms - +1.36ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +3% (-0.24ms - +0.52ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local929.96ms - 937.59ms-unsure 🔍
-1% - +0%
-10.13ms - +3.63ms
preact-main931.30ms - 942.75msunsure 🔍
-0% - +1%
-3.63ms - +10.13ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.25ms - 25.25ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main25.25ms - 25.25msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.56ms - 16.65ms-unsure 🔍
-0% - +0%
-0.04ms - +0.07ms
preact-main16.56ms - 16.63msunsure 🔍
-0% - +0%
-0.07ms - +0.04ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.63ms - 1.64ms-unsure 🔍
-1% - +0%
-0.01ms - +0.00ms
preact-main1.63ms - 1.65msunsure 🔍
-0% - +1%
-0.00ms - +0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.05ms - 69.89ms-unsure 🔍
-1% - +1%
-0.64ms - +0.71ms
preact-main68.90ms - 69.96msunsure 🔍
-1% - +1%
-0.71ms - +0.64ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local15.00ms - 15.50ms-unsure 🔍
-2% - +3%
-0.24ms - +0.52ms
preact-main14.83ms - 15.40msunsure 🔍
-3% - +2%
-0.52ms - +0.24ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.38ms - 17.14ms-unsure 🔍
-2% - +3%
-0.34ms - +0.53ms
preact-main16.45ms - 16.87msunsure 🔍
-3% - +2%
-0.53ms - +0.34ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.54ms - 4.54ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main4.54ms - 4.54msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local75.40ms - 78.10ms-unsure 🔍
-2% - +2%
-1.72ms - +1.85ms
preact-main75.51ms - 77.85msunsure 🔍
-2% - +2%
-1.85ms - +1.72ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.54ms - 3.56ms-unsure 🔍
-0% - +0%
-0.02ms - +0.01ms
preact-main3.54ms - 3.56msunsure 🔍
-0% - +0%
-0.01ms - +0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local30.30ms - 31.03ms-unsure 🔍
-1% - +2%
-0.15ms - +0.75ms
preact-main30.11ms - 30.62msunsure 🔍
-2% - +0%
-0.75ms - +0.15ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.03ms - 36.40ms-unsure 🔍
-3% - +2%
-0.97ms - +0.82ms
preact-main35.21ms - 36.37msunsure 🔍
-2% - +3%
-0.82ms - +0.97ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.47ms - 25.82ms-unsure 🔍
-1% - +1%
-0.28ms - +0.21ms
preact-main25.50ms - 25.85msunsure 🔍
-1% - +1%
-0.21ms - +0.28ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local28.98ms - 30.64ms-unsure 🔍
-3% - +5%
-0.97ms - +1.45ms
preact-main28.69ms - 30.45msunsure 🔍
-5% - +3%
-1.45ms - +0.97ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local20.47ms - 21.08ms-unsure 🔍
-1% - +3%
-0.19ms - +0.58ms
preact-main20.34ms - 20.82msunsure 🔍
-3% - +1%
-0.58ms - +0.19ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local23.98ms - 25.20ms-unsure 🔍
-3% - +4%
-0.70ms - +1.00ms
preact-main23.84ms - 25.03msunsure 🔍
-4% - +3%
-1.00ms - +0.70ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.96ms - 2.08ms-unsure 🔍
-5% - +4%
-0.10ms - +0.09ms
preact-main1.95ms - 2.09msunsure 🔍
-4% - +5%
-0.09ms - +0.10ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.08ms - 1.08ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.08ms - 1.08msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.09ms - 33.38ms-unsure 🔍
-1% - +1%
-0.28ms - +0.19ms
preact-main33.09ms - 33.47msunsure 🔍
-1% - +1%
-0.19ms - +0.28ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.19ms - 1.19ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.19ms - 1.19msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.45ms - 36.12ms-unsure 🔍
-2% - +4%
-0.78ms - +1.36ms
preact-main34.33ms - 35.67msunsure 🔍
-4% - +2%
-1.36ms - +0.78ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.49ms - 3.49ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.48ms - 3.49msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

Size Change: +69 B (+0.11%)

Total Size: 62 kB

Filename Size Change
dist/preact.js 4.66 kB +11 B (+0.24%)
dist/preact.min.js 4.69 kB +12 B (+0.26%)
dist/preact.min.module.js 4.68 kB +11 B (+0.24%)
dist/preact.min.umd.js 4.71 kB +12 B (+0.26%)
dist/preact.module.js 4.67 kB +12 B (+0.26%)
dist/preact.umd.js 4.73 kB +11 B (+0.23%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.11 kB
compat/dist/compat.module.js 4.04 kB
compat/dist/compat.umd.js 4.18 kB
debug/dist/debug.js 3.81 kB
debug/dist/debug.module.js 3.82 kB
debug/dist/debug.umd.js 3.89 kB
devtools/dist/devtools.js 259 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 345 B
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 981 B
jsx-runtime/dist/jsxRuntime.module.js 956 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Sep 12, 2024 •
edited
Loading

Coverage Status

coverage: 99.488% (+0.001%) from 99.487%
when pulling 54a1f24 on fix-undefined-null-progress
into 0943ac7 on main.

@JoviDeCroock JoviDeCroock force-pushed the fix-undefined-null-progress branch 2 times, most recently from aaa40dd to c7b6ea3 Compare September 12, 2024 16:59
@JoviDeCroock JoviDeCroock force-pushed the fix-undefined-null-progress branch from c7b6ea3 to 7c0ee5e Compare September 12, 2024 17:00
@JoviDeCroock JoviDeCroock merged commit df67ca0 into main Sep 13, 2024
@JoviDeCroock JoviDeCroock deleted the fix-undefined-null-progress branch September 13, 2024 10:08
@JoviDeCroock JoviDeCroock mentioned this pull request Sep 14, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Oct 5, 2024
Open
@lorenzoAtBEIS lorenzoAtBEIS mentioned this pull request Oct 7, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Oct 18, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 25, 2024
Open
@Xcaciv Xcaciv mentioned this pull request Oct 27, 2024
Open
@dwhiteGUK dwhiteGUK mentioned this pull request Oct 28, 2024
Closed
@X-oss-byte X-oss-byte mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Once <progress> value attribute has been set, it will never be removed.

4 participants

@JoviDeCroock @coveralls @marvinhagemeister