Skip to content

Commit 53f9d28

Browse files
committed
tests: some more fixes for 2.3.1
1 parent 60fba17 commit 53f9d28

File tree

2 files changed

+6
-16
lines changed

2 files changed

+6
-16
lines changed

tests/compatibility.py

+5-15
Original file line numberDiff line numberDiff line change
@@ -631,8 +631,7 @@ def test_backward_compatibility_merge_1(self):
631631
node.pgbench_init(scale=20)
632632

633633
# FULL backup with OLD binary
634-
self.backup_node(
635-
backup_dir, 'node', node, old_binary=True)
634+
self.backup_node(backup_dir, 'node', node, old_binary=True)
636635

637636
pgbench = node.pgbench(
638637
stdout=subprocess.PIPE,
@@ -643,8 +642,7 @@ def test_backward_compatibility_merge_1(self):
643642

644643
# PAGE1 backup with OLD binary
645644
self.backup_node(
646-
backup_dir, 'node', node,
647-
backup_type='page', old_binary=True, options=['--log-level-file=LOG'])
645+
backup_dir, 'node', node, backup_type='page', old_binary=True)
648646

649647
node.safe_psql(
650648
'postgres',
@@ -655,20 +653,13 @@ def test_backward_compatibility_merge_1(self):
655653
'VACUUM pgbench_accounts')
656654

657655
# PAGE2 backup with OLD binary
658-
self.backup_node(
659-
backup_dir, 'node', node,
660-
backup_type='page', old_binary=True, options=['--log-level-file=LOG'])
661-
662-
# PAGE3 backup with OLD binary
663656
backup_id = self.backup_node(
664-
backup_dir, 'node', node,
665-
backup_type='page', old_binary=True, options=['--log-level-file=LOG'])
657+
backup_dir, 'node', node, backup_type='page', old_binary=True)
666658

667659
pgdata = self.pgdata_content(node.data_dir)
668660

669661
# merge chain created by old binary with new binary
670-
output = self.merge_backup(
671-
backup_dir, "node", backup_id, options=['--log-level-file=LOG'])
662+
output = self.merge_backup(backup_dir, "node", backup_id)
672663

673664
# check that in-place is disabled
674665
self.assertIn(
@@ -680,8 +671,7 @@ def test_backward_compatibility_merge_1(self):
680671
base_dir=os.path.join(module_name, fname, 'node_restored'))
681672
node_restored.cleanup()
682673

683-
self.restore_node(
684-
backup_dir, 'node', node_restored, options=["-j", "4"])
674+
self.restore_node(backup_dir, 'node', node_restored)
685675

686676
pgdata_restored = self.pgdata_content(node_restored.data_dir)
687677
self.compare_pgdata(pgdata, pgdata_restored)

tests/option.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def test_options_4(self):
9494
except ProbackupException as e:
9595
self.assertIn(
9696
'ERROR: You must specify at least one of the delete options: '
97-
'--delete-expired |--delete-wal |--merge-expired |(-i, --backup-id)',
97+
'--delete-expired |--delete-wal |--merge-expired |--status |(-i, --backup-id)',
9898
e.message,
9999
'\n Unexpected Error Message: {0}\n CMD: {1}'.format(repr(e.message), self.cmd))
100100

0 commit comments

Comments
 (0)