Ensure prompts related to environment selection do not show up at startup (microsoft/vscode-python#19483)

Author: Kartik Raj

extensions/positron-python/src/client/application/diagnostics/checks/pythonInterpreter.ts

@@ -100,7 +100,12 @@ export class InvalidPythonInterpreterService extends BaseDiagnosticsService
         );
     }
 
-    public async diagnose(resource: Resource): Promise<IDiagnostic[]> {
+    // eslint-disable-next-line class-methods-use-this
+    public async diagnose(_resource: Resource): Promise<IDiagnostic[]> {
+        return [];
+    }
+
+    public async _manualDiagnose(resource: Resource): Promise<IDiagnostic[]> {
         const workspaceService = this.serviceContainer.get<IWorkspaceService>(IWorkspaceService);
         const interpreterService = this.serviceContainer.get<IInterpreterService>(IInterpreterService);
         const hasInterpreters = await interpreterService.hasInterpreters();
@@ -130,7 +135,7 @@ export class InvalidPythonInterpreterService extends BaseDiagnosticsService
     }
 
     public async triggerEnvSelectionIfNecessary(resource: Resource): Promise<boolean> {
-        const diagnostics = await this.diagnose(resource);
+        const diagnostics = await this._manualDiagnose(resource);
         if (!diagnostics.length) {
             return true;
         }

extensions/positron-python/src/test/application/diagnostics/checks/pythonInterpreter.unit.test.ts

@@ -6,7 +6,6 @@
 import { expect } from 'chai';
 import * as typemoq from 'typemoq';
 import { EventEmitter, Uri } from 'vscode';
-import { IExtensionSingleActivationService } from '../../../../client/activation/types';
 import { BaseDiagnosticsService } from '../../../../client/application/diagnostics/base';
 import { InvalidLaunchJsonDebuggerDiagnostic } from '../../../../client/application/diagnostics/checks/invalidLaunchJsonDebugger';
 import {
@@ -24,7 +23,6 @@ import {
     IDiagnostic,
     IDiagnosticCommand,
     IDiagnosticHandlerService,
-    IDiagnosticsService,
 } from '../../../../client/application/diagnostics/types';
 import { CommandsWithoutArgs } from '../../../../client/common/application/commands';
 import { ICommandManager, IWorkspaceService } from '../../../../client/common/application/types';
@@ -39,7 +37,7 @@ import { EnvironmentType, PythonEnvironment } from '../../../../client/pythonEnv
 import { sleep } from '../../../core';
 
 suite('Application Diagnostics - Checks Python Interpreter', () => {
-    let diagnosticService: IDiagnosticsService & IExtensionSingleActivationService;
+    let diagnosticService: InvalidPythonInterpreterService;
     let messageHandler: typemoq.IMock<IDiagnosticHandlerService<MessageCommandPrompt>>;
     let commandFactory: typemoq.IMock<IDiagnosticsCommandFactory>;
     let interpreterService: typemoq.IMock<IInterpreterService>;
@@ -157,6 +155,11 @@ suite('Application Diagnostics - Checks Python Interpreter', () => {
             }
         });
 
+        test('Should return empty diagnostics', async () => {
+            const diagnostics = await diagnosticService.diagnose(undefined);
+            expect(diagnostics).to.be.deep.equal([], 'not the same');
+        });
+
         test('Should return diagnostics if there are no interpreters after double-checking', async () => {
             interpreterService
                 .setup((i) => i.hasInterpreters())
@@ -167,7 +170,7 @@ suite('Application Diagnostics - Checks Python Interpreter', () => {
                 .returns(() => [])
                 .verifiable(typemoq.Times.once());
 
-            const diagnostics = await diagnosticService.diagnose(undefined);
+            const diagnostics = await diagnosticService._manualDiagnose(undefined);
             expect(diagnostics).to.be.deep.equal(
                 [
                     new InvalidPythonInterpreterDiagnostic(
@@ -192,7 +195,7 @@ suite('Application Diagnostics - Checks Python Interpreter', () => {
                 })
                 .verifiable(typemoq.Times.once());
 
-            const diagnostics = await diagnosticService.diagnose(undefined);
+            const diagnostics = await diagnosticService._manualDiagnose(undefined);
             expect(diagnostics).to.be.deep.equal(
                 [
                     new InvalidPythonInterpreterDiagnostic(
@@ -217,7 +220,7 @@ suite('Application Diagnostics - Checks Python Interpreter', () => {
                 })
                 .verifiable(typemoq.Times.once());
 
-            const diagnostics = await diagnosticService.diagnose(undefined);
+            const diagnostics = await diagnosticService._manualDiagnose(undefined);
             expect(diagnostics).to.be.deep.equal([], 'not the same');
             interpreterService.verifyAll();
         });