Remove unwanted properties (microsoft/vscode-python#20045)

Follow-up to microsoft/vscode-python#20024

Author: Kartik Raj

extensions/positron-python/package.json

@@ -1605,12 +1605,6 @@
                     "title": "%python.command.python.execSelectionInTerminal.title%",
                     "when": "!virtualWorkspace && shellExecutionSupported"
                 },
-                {
-                    "category": "Python",
-                    "command": "python.goToPythonObject",
-                    "title": "%python.command.python.goToPythonObject.title%",
-                    "when": "!virtualWorkspace && shellExecutionSupported"
-                },
                 {
                     "category": "Python",
                     "command": "python.launchTensorBoard",

extensions/positron-python/package.nls.json

@@ -15,7 +15,6 @@
     "python.command.testing.rerunFailedTests.title": "Rerun Failed Tests",
     "python.command.python.execSelectionInTerminal.title": "Run Selection/Line in Python Terminal",
     "python.command.python.execSelectionInDjangoShell.title": "Run Selection/Line in Django Shell",
-    "python.command.python.goToPythonObject.title": "Go to Python Object",
     "python.command.python.reportIssue.title": "Report Issue...",
     "python.command.python.setLinter.title": "Select Linter",
     "python.command.python.enableLinting.title": "Enable/Disable Linting",

extensions/positron-python/src/client/activation/jedi/languageServerProxy.ts

@@ -52,12 +52,15 @@ export class JediLanguageServerProxy implements ILanguageServerProxy {
             (options.middleware ? (<JediLanguageClientMiddleware>options.middleware).serverVersion : undefined) ??
             '0.19.3';
 
-        const client = await this.factory.createLanguageClient(resource, interpreter, options);
-        this.registerHandlers(client);
-
-        await client.start();
-
-        this.languageClient = client;
+        try {
+            const client = await this.factory.createLanguageClient(resource, interpreter, options);
+            this.registerHandlers(client);
+            await client.start();
+            this.languageClient = client;
+        } catch (ex) {
+            traceError('Failed to start language server:', ex);
+            throw new Error('Launching Jedi language server using python failed, see output.');
+        }
     }
 
     @traceDecoratorVerbose('Stopping language server')

extensions/positron-python/src/client/browser/extension.ts

@@ -194,7 +194,6 @@ function sendTelemetryEventBrowser(
     if (ex) {
         const errorProps = {
             errorName: ex.name,
-            errorMessage: ex.message,
             errorStack: ex.stack ?? '',
         };
         Object.assign(customProperties, errorProps);

extensions/positron-python/src/client/interpreter/activation/service.ts

@@ -159,15 +159,10 @@ export class EnvironmentActivationService implements IEnvironmentActivationServi
                 return vars;
             })
             .catch((ex) => {
-                let excString = (ex as Error).toString();
-                if (interpreter?.envName) {
-                    excString = excString.replaceAll(interpreter.envName, '<env name>');
-                }
                 sendTelemetryEvent(
                     EventName.PYTHON_INTERPRETER_ACTIVATION_ENVIRONMENT_VARIABLES,
                     stopWatch.elapsedTime,
                     { failed: true },
-                    new Error(excString),
                 );
                 throw ex;
             });

extensions/positron-python/src/client/telemetry/index.ts

@@ -150,7 +150,6 @@ export function sendTelemetryEvent<P extends IEventNamePropertyMapping, E extend
     if (ex) {
         const errorProps = {
             errorName: ex.name,
-            errorMessage: ex.message,
             errorStack: ex.stack ?? '',
         };
         Object.assign(customProperties, errorProps);

extensions/positron-python/src/test/telemetry/index.unit.test.ts

@@ -166,7 +166,6 @@ suite('Telemetry', () => {
         const expectedProperties = {
             ...properties,
             errorName: error.name,
-            errorMessage: error.message,
             errorStack: error.stack,
         };