-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Memory leaks on page refresh #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Please try |
I updated the codesandbox to be v9.0.0-rc.3. Same issue. Just for the sake of visualizing, here's a heap allocation timeline while I refresh the app: |
You can reproduce outside of CodeSandbox? |
@aleclarson Yes I can. I am actually doing something very similar (a simple count up animation) in a next.js app. Simply creating a spring using |
Ah, I looked over the detail that you're using NextJS. See here: #778 |
@aleclarson Thanks for that link I'm following that thread now. One thing that might be worth noting is that the codesandbox is not actually using ssr/nextjs, although i did discover the issue initially in a next app. |
🐛 Bug Report
When refreshing a page that is using useSpring or Spring renderprop I'm noticing a memory leak
To Reproduce
Expected behavior
Expected memory to be garbage collected on refresh
Environment
Although I am running react-spring 9 i have noticed the same issue on the latest react-spring
react-spring
v9.0.0-beta.34react
v16.13.1 (latest)next
v9.4.4 (latest)The text was updated successfully, but these errors were encountered: