Skip to content

Minimize unnecessary plotprops computation #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpostlethwaite opened this issue Nov 13, 2017 · 2 comments
Closed

Minimize unnecessary plotprops computation #61

bpostlethwaite opened this issue Nov 13, 2017 · 2 comments
Assignees
@bpostlethwaite

Comments

@bpostlethwaite
Copy link
Member

When application logic changes unpackPlotProps is run on every rendered attribute Field. Investigate a way to prevent this from happening. Probably worth starting with the Editor revision number ++
@bpostlethwaite bpostlethwaite mentioned this issue Nov 19, 2017
Closed
@bpostlethwaite
Copy link
Member Author

Could move figure dereferencing into DataSelector update. It has the info to do targeted updating. That means we don't have to walk the figure each render.

@bpostlethwaite bpostlethwaite mentioned this issue Nov 23, 2017
Merged
@bpostlethwaite bpostlethwaite self-assigned this Nov 23, 2017
@bpostlethwaite
Copy link
Member Author

closed by #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpostlethwaite bpostlethwaite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bpostlethwaite