fix issues and awesome improvements in fsurf functionality #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gilbertogalvis merged 1 commit into master from fix_issues_and_awesome_improvements_in_fsurf_functionality

Sep 14, 2021

Contributor

gilbertogalvis commented Sep 13, 2021

This PR fix issues and do awesome improvements with fsurf functionality. fsurf previous version was very poor. This new version is really awesome. This PR was tested for all examples in https://github.com/plotly/ssim_baselines/tree/main/matlab/code-examples/surface-and-mesh-plots/fsurf

r = @(u,v) 2 + sin(7.*u + 5.*v);
funx = @(u,v) r(u,v).*cos(u).*sin(v);
funy = @(u,v) r(u,v).*sin(u).*sin(v);
funz = @(u,v) r(u,v).*cos(v);
fsurf(funx,funy,funz,[0 2*pi 0 pi]) 
camlight;

f = fig2plotly(gcf, 'offline', true);

Screenshots of results are shown bellow

Links to Chart-Studio

https://chart-studio.plotly.com/~galvisgilberto/4366/#/
https://chart-studio.plotly.com/~galvisgilberto/4368/#/
https://chart-studio.plotly.com/~galvisgilberto/4370/#/
https://chart-studio.plotly.com/~galvisgilberto/4372/textysinx-xcosy-for-x-and-y-in-2pi-text2pi-text/#/
https://chart-studio.plotly.com/~galvisgilberto/4374/textysinx-xcosy-for-x-and-y-in-2pi-text2pi-text/#/
https://chart-studio.plotly.com/~galvisgilberto/4376/#/
https://chart-studio.plotly.com/~galvisgilberto/4378/#/
https://chart-studio.plotly.com/~galvisgilberto/4380/#/
https://chart-studio.plotly.com/~galvisgilberto/4382/#/
https://chart-studio.plotly.com/~galvisgilberto/4384/#/
https://chart-studio.plotly.com/~galvisgilberto/4386/default-meshdensity-35/#/


          fix issues and awesome improvements in fsurf functionality

9cc18d7

gilbertogalvis merged commit 7cb06de into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet