Skip to content

Add RTL for mapbox #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rahimramezanian opened this issue Feb 21, 2018 · 3 comments
Closed

Add RTL for mapbox #2390

rahimramezanian opened this issue Feb 21, 2018 · 3 comments
Labels
community community contribution feature something new

Comments

@rahimramezanian
Copy link

There is a mapbox library

https://github.com/mapbox/mapbox-gl-rtl-text

which fixes the right to left names over map. It will be nice to add this feature too.

@alexcjohnson
Copy link
Collaborator

Thanks, that does seem like a nice feature to add. I'm not sure though that I would know what success looks like, not being familiar with any RTL languages and specifically how they're used on maps. But we would be happy to look at a pull request that includes a test image locking down how it works!

@alexcjohnson alexcjohnson added the feature something new label Feb 21, 2018
@etpinard etpinard added the community community contribution label Feb 21, 2018
@etpinard
Copy link
Contributor

Hmm. This would add minified 200kb to our mapbox bundles. Maybe it would be best to come up with a plugin system for mapbox plugins?

@gvwilson
Copy link
Contributor

Hi - this issue has been sitting for a while, so as part of our effort to tidy up our public repositories I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our stack. Cheers - @gvwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new
Projects
None yet
Development

No branches or pull requests

4 participants