Skip to content

Commit f528e74

Browse files
authored
Merge pull request #7381 from chaigh-uk/fix-deps-node-22
Fix: Fix installing dependencies in node v22
2 parents b560368 + 2bbaec5 commit f528e74

File tree

4 files changed

+587
-500
lines changed

4 files changed

+587
-500
lines changed

.circleci/config.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ jobs:
407407
name: Run syntax tests on source files
408408
command: .circleci/test.sh source-syntax
409409

410-
publish-dist:
410+
publish-dist: &publish-dist
411411
docker:
412412
- image: cimg/node:18.20.4
413413
working_directory: ~/plotly.js
@@ -465,6 +465,11 @@ jobs:
465465
name: Test plot-schema.json diff - If failed, after (npm start) you could run (npm run schema && git add test/plot-schema.json && git commit -m "update plot-schema diff")
466466
command: diff --unified --color dist/plot-schema.json test/plot-schema.json
467467

468+
publish-dist-node-v22:
469+
<<: *publish-dist
470+
docker:
471+
- image: cimg/node:22.14.0
472+
468473
test-stackgl-bundle:
469474
docker:
470475
- image: cimg/node:18.20.4
@@ -552,4 +557,6 @@ workflows:
552557

553558
- publish-dist
554559

560+
- publish-dist-node-v22
561+
555562
- test-stackgl-bundle

draftlogs/7381_fix.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Fix installing dependencies in node v22 [[#7381](https://github.com/plotly/plotly.js/pull/7381)], with thanks to @chaigh-uk for the contribution!

0 commit comments

Comments
 (0)