Standardize to 1px blur and equal x/y offsets

Author: jonmmease

src/lib/svg_text_utils.js

@@ -755,15 +755,14 @@ function alignHTMLWith(_base, container, options) {
     };
 }
 
-exports.makeTextShadow = function(offsetX, offsetY, blurRadius, color) {
-    var x = offsetX + 'px ';
-    var y = offsetY + 'px ';
-    var b = blurRadius + 'px ';
-    var clr = color + ' ';
-    return x + y + b + clr + ', ' +
-        '-' + x + '-' + y + b + clr + ', ' +
-        x + '-' + y + b + clr + ', ' +
-        '-' + x + y + b + clr;
+exports.makeTextShadow = function(offset, color) {
+    var x = offset + 'px ';
+    var y = offset + 'px ';
+    var b = '1px ';
+    return x + y + b + color + ', ' +
+        '-' + x + '-' + y + b + color + ', ' +
+        x + '-' + y + b + color + ', ' +
+        '-' + x + y + b + color;
 };
 
 /*

src/traces/parcats/parcats.js

@@ -238,7 +238,7 @@ function performPlot(parcatsModels, graphDiv, layout, svg) {
             })
         .attr('alignment-baseline', 'middle')
 
-        .style('text-shadow', svgTextUtils.makeTextShadow(1, 1, 2, paperColor))
+        .style('text-shadow', svgTextUtils.makeTextShadow(1, paperColor))
         .style('fill', 'rgb(0, 0, 0)')
         .attr('x',
             function(d) {

src/traces/parcoords/parcoords.js

@@ -649,7 +649,7 @@ module.exports = function parcoords(gd, cdModule, layout, callbacks) {
         .attr('stroke-width', '1px');
 
     axis.selectAll('text')
-        .style('text-shadow', svgTextUtils.makeTextShadow(1, 1, 1, paperColor))
+        .style('text-shadow', svgTextUtils.makeTextShadow(1, paperColor))
         .style('cursor', 'default');
 
     var axisHeading = axisOverlays.selectAll('.' + c.cn.axisHeading)

src/traces/sankey/render.js

@@ -1025,7 +1025,7 @@ module.exports = function(gd, svg, calcData, layout, callbacks) {
 
     nodeLabel
         .style('text-shadow', function(d) {
-            return d.horizontal ? svgTextUtils.makeTextShadow(1, 1, 1, '#fff') : 'none';
+            return d.horizontal ? svgTextUtils.makeTextShadow(1, '#fff') : 'none';
         })
         .each(function(d) {Drawing.font(nodeLabel, d.textFont);});