Skip to content

Commit 84c3606

Browse files
committed
fixup funnel test for new _length===0 logic
1 parent a20cb01 commit 84c3606

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

test/jasmine/tests/funnel_test.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1018,7 +1018,7 @@ describe('A funnel plot', function() {
10181018
.then(done);
10191019
});
10201020

1021-
it('should be able to deal with blank bars on transform', function(done) {
1021+
it('should be able to deal with transform that empty out the data coordinate arrays', function(done) {
10221022
Plotly.plot(gd, {
10231023
data: [{
10241024
type: 'funnel',
@@ -1038,14 +1038,11 @@ describe('A funnel plot', function() {
10381038
})
10391039
.then(function() {
10401040
var traceNodes = getAllTraceNodes(gd);
1041-
var funnelNodes = getAllFunnelNodes(traceNodes[0]);
1042-
var pathNode = funnelNodes[0].querySelector('path');
1041+
expect(traceNodes.length).toBe(0);
10431042

10441043
expect(gd.calcdata[0][0].x).toEqual(NaN);
10451044
expect(gd.calcdata[0][0].y).toEqual(NaN);
1046-
expect(gd.calcdata[0][0].isBlank).toBe(true);
1047-
1048-
expect(pathNode.outerHTML).toEqual('<path d="M0,0Z" style="vector-effect: non-scaling-stroke;"></path>');
1045+
expect(gd.calcdata[0][0].isBlank).toBe(undefined);
10491046
})
10501047
.catch(failTest)
10511048
.then(done);

0 commit comments

Comments
 (0)