Skip to content

Commit 3f664a1

Browse files
committed
apply minBorderWidth only for noBorder and noFill symbols
1 parent da89728 commit 3f664a1

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/traces/scattergl/convert.js

+2-6
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ proto.updateFancy = function(options) {
533533

534534
size = sizes[index];
535535
bw = borderWidths[index];
536-
minBorderWidth = 0.1 * size;
536+
minBorderWidth = (symbolSpec.noBorder || symbolSpec.noFill) ? 0.1 * size : 0;
537537

538538
this.scatter.options.sizes[i] = 4.0 * size;
539539
this.scatter.options.glyphs[i] = symbolSpec.unicode;
@@ -544,11 +544,7 @@ proto.updateFancy = function(options) {
544544
// already baked into the unicode symbol, so the symbol gets no
545545
// explicit border until you provide a width greater than this, and
546546
// at greater widths you set a border borderWidth - minBorderWidth.
547-
548-
//this.scatter.options.borderWidths[i] = (bw > minBorderWidth) ? bw - minBorderWidth : 0;
549-
550-
// but I found better results with:
551-
this.scatter.options.borderWidths[i] = (bw > minBorderWidth) ? bw - minBorderWidth : bw;
547+
this.scatter.options.borderWidths[i] = (bw > minBorderWidth) ? bw - minBorderWidth : 0;
552548

553549
if(isOpen && !symbolSpec.noBorder && !symbolSpec.noFill) {
554550
fillColor(this.scatter.options.colors, transparent, i, 0);
764 Bytes
Loading

0 commit comments

Comments
 (0)