Skip to content

Commit 33b72e1

Browse files
committed
fix missing catch and done in pie tests
1 parent 3a313e7 commit 33b72e1

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

test/jasmine/tests/pie_test.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1608,7 +1608,7 @@ describe('Test event data of interactions on a pie plot:', function() {
16081608
checkEventData(futureData);
16091609
});
16101610

1611-
it('should not contain pointNumber if aggregating', function() {
1611+
it('should not contain pointNumber if aggregating', function(done) {
16121612
var values = gd.data[0].values;
16131613
var labels = [];
16141614
for(var i = 0; i < values.length; i++) labels.push(i);
@@ -1623,7 +1623,9 @@ describe('Test event data of interactions on a pie plot:', function() {
16231623
expect(futureData.points[0].pointNumber).toBeUndefined();
16241624
expect(futureData.points[0].i).toBeUndefined();
16251625
expect(futureData.points[0].pointNumbers).toEqual([4, 9]);
1626-
});
1626+
})
1627+
.catch(failTest)
1628+
.then(done);
16271629
});
16281630
});
16291631

@@ -1699,12 +1701,14 @@ describe('Test event data of interactions on a pie plot:', function() {
16991701
expect(futureData).toBe(null);
17001702
});
17011703

1702-
it('should not emit a hover if hover is disabled', function() {
1704+
it('should not emit a hover if hover is disabled', function(done) {
17031705
Plotly.relayout(gd, 'hovermode', false)
17041706
.then(function() {
17051707
mouseEvent('mouseover', pointPos[0], pointPos[1]);
17061708
expect(futureData).toBe(null);
1707-
});
1709+
})
1710+
.catch(failTest)
1711+
.then(done);
17081712
});
17091713
});
17101714

0 commit comments

Comments
 (0)