Properly retain original opacity of 0 (0 is falsy in JavaScript), closes #1406

cpsievert · cpsievert · commit f3d22ce2ac93 · 2018-11-15T13:41:02.000-06:00
diff --git a/inst/htmlwidgets/plotly.js b/inst/htmlwidgets/plotly.js
@@ -522,7 +522,7 @@ function TraceManager(graphDiv, highlight) {
   // avoid doing this over and over
   this.origOpacity = [];
   for (var i = 0; i < this.origData.length; i++) {
-    this.origOpacity[i] = this.origData[i].opacity || 1;
+    this.origOpacity[i] = this.origData[i].opacity === 0 ? 0 : (this.origData[i].opacity || 1);
   }
 
   // key: group name, value: null or array of keys representing the

Original file line number	Diff line number	Diff line change
`@@ -522,7 +522,7 @@ function TraceManager(graphDiv, highlight) {`
`522`	`522`	`// avoid doing this over and over`
`523`	`523`	`this.origOpacity = [];`
`524`	`524`	`for (var i = 0; i < this.origData.length; i++) {`
`525`		`- this.origOpacity[i] = this.origData[i].opacity \|\| 1;`
	`525`	`+ this.origOpacity[i] = this.origData[i].opacity === 0 ? 0 : (this.origData[i].opacity \|\| 1);`
`526`	`526`	`}`
`527`	`527`
`528`	`528`	`// key: group name, value: null or array of keys representing the`