Skip to content

Commit eb915bf

Browse files
committed
Multiplier to paramORdefault()
1 parent d5cc3aa commit eb915bf

File tree

2 files changed

+47
-58
lines changed

2 files changed

+47
-58
lines changed

R/marker_conversion.R

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,17 @@
55
##' @export
66
##' @return named list.
77
##' @author Toby Dylan Hocking
8-
paramORdefault <- function(params, aesVec, defaults){
8+
paramORdefault <- function(params, aesVec, defaults) {
99
marker <- list()
1010
for(ggplot.name in names(aesVec)){
1111
plotly.name <- aesVec[[ggplot.name]]
1212
ggplot.value <- params[[ggplot.name]]
1313
if(is.null(ggplot.value)){
1414
ggplot.value <- defaults[[ggplot.name]]
1515
}
16+
if(plotly.name=="width"){
17+
ggplot.value <- ggplot.value * 2
18+
}
1619
if(is.null(ggplot.value)){
1720
stop("no ggplot default for ", ggplot.name)
1821
}

R/trace_generation.R

Lines changed: 43 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -359,28 +359,24 @@ group2NA <- function(g, geom){
359359
# Convert basic geoms to traces.
360360
geom2trace <- list(
361361
path=function(data, params) {
362-
L <- list(x=data$x,
363-
y=data$y,
364-
name=params$name,
365-
text=data$text,
366-
type="scatter",
367-
mode="lines",
368-
line=paramORdefault(params, aes2line, line.defaults))
369-
L$line$width <- L$line$width * 2
370-
L
362+
list(x=data$x,
363+
y=data$y,
364+
name=params$name,
365+
text=data$text,
366+
type="scatter",
367+
mode="lines",
368+
line=paramORdefault(params, aes2line, line.defaults))
371369
},
372370
polygon=function(data, params){
373-
L <- list(x=c(data$x, data$x[1]),
374-
y=c(data$y, data$y[1]),
375-
name=params$name,
376-
text=data$text,
377-
type="scatter",
378-
mode="lines",
379-
line=paramORdefault(params, aes2line, line.defaults),
380-
fill="tonextx",
381-
fillcolor=toRGB(params$fill))
382-
L$line$width <- L$line$width * 2
383-
L
371+
list(x=c(data$x, data$x[1]),
372+
y=c(data$y, data$y[1]),
373+
name=params$name,
374+
text=data$text,
375+
type="scatter",
376+
mode="lines",
377+
line=paramORdefault(params, aes2line, line.defaults),
378+
fill="tonextx",
379+
fillcolor=toRGB(params$fill))
384380
},
385381
point=function(data, params){
386382
L <- list(x=data$x,
@@ -456,14 +452,12 @@ geom2trace <- list(
456452
L
457453
},
458454
step=function(data, params) {
459-
L <- list(x=data$x,
460-
y=data$y,
461-
name=params$name,
462-
type="scatter",
463-
mode="lines",
464-
line=paramORdefault(params, aes2line, line.defaults))
465-
L$line$width <- L$line$width * 2
466-
L
455+
list(x=data$x,
456+
y=data$y,
457+
name=params$name,
458+
type="scatter",
459+
mode="lines",
460+
line=paramORdefault(params, aes2line, line.defaults))
467461
},
468462
tile=function(data, params) {
469463
list(x=unique(data$x),
@@ -488,26 +482,24 @@ geom2trace <- list(
488482
name=params$name,
489483
type="contour",
490484
line=paramORdefault(params, aes2line, line.defaults))
491-
L$line$width <- L$line$width * 2
492485
L$contours=list(coloring="lines")
493486
L
494487
},
495488
density=function(data, params) {
496-
L <- list(x=data$x,
497-
name=params$name,
498-
text=data$text,
499-
marker=list(color=toRGB(params$fill)),
500-
type="histogram",
501-
autobinx=TRUE,
502-
histnorm="probability density")
489+
list(x=data$x,
490+
name=params$name,
491+
text=data$text,
492+
marker=list(color=toRGB(params$fill)),
493+
type="histogram",
494+
autobinx=TRUE,
495+
histnorm="probability density")
503496
},
504497
density2d=function(data, params) {
505498
L <- list(x=data$x,
506499
y=data$y,
507500
name=params$name,
508501
type="histogram2dcontour",
509502
line=paramORdefault(params, aes2line, line.defaults))
510-
L$line$width <- L$line$width * 2
511503
L$contours=list(coloring="lines")
512504
L
513505
},
@@ -539,34 +531,28 @@ geom2trace <- list(
539531
fill="tonexty")
540532
},
541533
abline=function(data, params) {
542-
L <- list(x=c(params$xstart, params$xend),
543-
y=c(params$intercept + params$xstart * params$slope,
544-
params$intercept + params$xend * params$slope),
545-
name=params$name,
546-
type="scatter",
547-
mode="lines",
548-
line=paramORdefault(params, aes2line, line.defaults))
549-
L$line$width <- L$line$width * 2
550-
L
534+
list(x=c(params$xstart, params$xend),
535+
y=c(params$intercept + params$xstart * params$slope,
536+
params$intercept + params$xend * params$slope),
537+
name=params$name,
538+
type="scatter",
539+
mode="lines",
540+
line=paramORdefault(params, aes2line, line.defaults))
551541
},
552542
hline=function(data, params) {
553-
L <- list(x=c(params$xstart, params$xend),
543+
list(x=c(params$xstart, params$xend),
554544
y=c(data$yintercept, data$yintercept),
555545
name=params$name,
556546
type="scatter",
557547
mode="lines",
558548
line=paramORdefault(params, aes2line, line.defaults))
559-
L$line$width <- L$line$width * 2
560-
L
561549
},
562550
vline=function(data, params) {
563-
L <- list(x=c(data$xintercept, data$xintercept),
564-
y=c(params$ystart, params$yend),
565-
name=params$name,
566-
type="scatter",
567-
mode="lines",
568-
line=paramORdefault(params, aes2line, line.defaults))
569-
L$line$width <- L$line$width * 2
570-
L
551+
list(x=c(data$xintercept, data$xintercept),
552+
y=c(params$ystart, params$yend),
553+
name=params$name,
554+
type="scatter",
555+
mode="lines",
556+
line=paramORdefault(params, aes2line, line.defaults))
571557
}
572558
)

0 commit comments

Comments
 (0)