Merge pull request #651 from ropensci/fix/symbol

Bug fixes

Author: cpsievert

R/plotly_build.R

@@ -533,7 +533,7 @@ map_symbol <- function(traces) {
   palette <- setNames(symbols[seq_len(N)], unique(symbol))
   for (i in which(nSymbols > 0)) {
     s <- symbolList[[i]]
-    symbols <- pch2symbol(if (inherits(s, "AsIs")) s else as.character(palette[s]))
+    symbols <- pch2symbol(if (inherits(s, "AsIs")) s else as.character(palette[as.character(s)]))
     illegalSymbols <- setdiff(symbols, validSymbols)
     if (length(illegalSymbols)) {
       warning(
@@ -581,7 +581,7 @@ map_linetype <- function(traces) {
   palette <- setNames(linetypes[seq_len(N)], unique(linetype))
   for (i in which(nLinetypes > 0)) {
     l <- linetypeList[[i]]
-    dashes <- lty2dash(if (inherits(l, "AsIs")) l else as.character(palette[l]))
+    dashes <- lty2dash(if (inherits(l, "AsIs")) l else as.character(palette[as.character(l)]))
     illegalLinetypes <- setdiff(dashes, validLinetypes)
     if (length(illegalLinetypes)) {
       warning(

tests/testthat/test-plotly-symbol.R

@@ -37,3 +37,12 @@ test_that("Warn about invalid symbol codes", {
   p <- plot_ly(iris, x = ~Sepal.Length, y = ~Petal.Length, symbol = I("DNE"))
   expect_warning(plotly_build(p), "DNE")
 })
+
+test_that("Formula resulting in logical vector works", {
+  s <- c("triangle-up", "circle-open")
+  p <- plot_ly(x = 1:10, y = 1:10, symbol = ~1:10 > 5, symbols = s)
+  l <- expect_traces(p, 2, "logical")
+  markers <- lapply(l$data, "[[", "marker")
+  syms <- unlist(lapply(markers, "[[", "symbol"))
+  expect_identical(syms, s)
+})