Duplicated values of positional attributes are no longer removed

Author: cpsievert

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: plotly
 Title: Create Interactive Web Graphics via 'plotly.js'
-Version: 4.0.0
+Version: 4.0.1
 Authors@R: c(person("Carson", "Sievert", role = c("aut", "cre"),
     email = "[email protected]"),
     person("Chris", "Parmer", role = c("aut", "cph"),

NEWS.md

@@ -1,22 +1,29 @@
-4.0.1 -- 14 June 2016
+# 4.0.1 -- 14 June 2016
+
+## BUG FIXES
+
+* Duplicated values of positional attributes are no longer removed (bug was introduced in v4.0.0).
+
+## OTHER CHANGES
 
 * Upgraded to plotly.js v1.14.2 -- https://github.com/plotly/plotly.js/releases/tag/v1.14.2
 
-4.0.0 -- 13 June 2016
+# 4.0.0 -- 13 June 2016
 
-BREAKING CHANGES & IMPROVEMENTS:
+## BREAKING CHANGES & IMPROVEMENTS:
 
-* Formulas (instead of plain expressions) are now required when using variable mappings. For example, `plot_ly(mtcars, x = wt, y = mpg, color = vs)` should now be `plot_ly(mtcars, x = ~wt, y = ~mpg, color = ~vs)`. This is a major breaking change, but it is necessary to ensure that evaluation is correct in all contexts (as a result, `evaluate` argument is now deprecated as it is no longer needed). It also has the benefit of being easier to program with (i.e., writing your own custom functions that wrap `plot_ly()`). For more details, see the [lazyeval vignette](https://github.com/hadley/lazyeval/blob/master/vignettes/lazyeval.Rmd)
+* Formulas (instead of plain expressions) are now required when using variable mappings. For example, `plot_ly(mtcars, x = wt, y = mpg, color = vs)` should now be `plot_ly(mtcars, x = ~wt, y = ~mpg, color = ~vs)`. This is a major breaking change, but it is necessary to ensure that evaluation is correct in all contexts (as a result, `evaluate` argument is now deprecated as it is no longer needed). It also has the benefit of being easier to program with (i.e., writing your own custom functions that wrap `plot_ly()`) since it preserves [referential transparency](https://en.wikipedia.org/wiki/Referential_transparency). For more details, see the [lazyeval vignette](https://github.com/hadley/lazyeval/blob/master/vignettes/lazyeval.Rmd)
 * The data structure used to represent plotly objects is now an htmlwidget object (instead of a data frame with a special attribute tracking visual mappings). As a result, the `as.widget()` function has been deprecated, and [serialization/memory leak problems](https://github.com/rstudio/shiny/issues/1151) are no longer an issue. This change also implies that arbitrary data manipulation functions can no longer be intermingled inside a plot pipeline, but plotly methods for dplyr's data manipulation verbs are now provided (see `?plotly_data` for examples).
 * The `group` variable mapping no longer create multiple traces, but instead defines "gaps" within a trace (fixes #418, #381, #577). Groupings should be declared via the new `group_by()` function (see `help(plotly_data)` for examples) instead of the `group` argument (which is now deprecated).
 * `plot_ly()` now _initializes_ a plotly object (i.e., won't add a scatter trace by default), meaning that something like `plot_ly(x = 1:10, y = 1:10) %>% add_trace(y = 10:1)` creates one trace, instead of two. That being said, if you manually specify a trace type in `plot_ly()`, it will add a layer with that trace type (e.g. `plot_ly(x = 1:10, y = 1:10, type = "scatter") %>% add_trace(y = 10:1)` draws two scatter traces). If no trace type is provided, a sensible type is inferred from the supplied data, and automatically added (i.e., `plot_ly(x = rnorm(100))` now creates a histogram).
 * The `inherit` argument is deprecated. Any arguments/attributes specified in `plot_ly()` will automatically be passed along to additional traces added via `add_trace()` (or any of it's `add_*()` siblings).
 * Aesthetic scaling (e.g., `color`, `symbol`, `size`) is applied at the plot-level, instead of the trace level. 
+* Size is no longer automatically included in hovertext (closes #549).
 
-NEW FEATURES & IMPROVEMENTS:
+## NEW FEATURES & IMPROVEMENTS:
 
 * Added `linetype`/`linetypes` arguments for mapping discrete variables to line types (works very much like the `symbol`/`symbols`).
-* Scaling for aesthetics can be avoided via `I()` (closes #428). This is mainly useful for changing default appearance (e.g. `plot_ly(x = 1:10, y = 1:10, color = I(rainbow(10)))`).
+* Scaling for aesthetics can be avoided via `I()` (closes #428). This is mainly useful for changing default appearance (e.g. `plot_ly(x = 1:10, y = 1:10, color = I("red"))`).
 * Symbols and linetypes now recognize `pch` and `lty` values (e.g. `plot_ly(x = 1:25, y = 1:25, symbol = I(0:24))`)
 * A new `alpha` argument controls the alpha transparency of `color` (e.g. `plot_ly(x = 1:10, y = 1:10, color = I("red"), alpha = 0.1)`).
 * Added a `sizes` argument for controlling the range of marker size scaling.
@@ -28,7 +35,7 @@ NEW FEATURES & IMPROVEMENTS:
 * New `plotly_json()` function for inspecting the data sent to plotly.js (as an R list or JSON).
 * `layout()` is now a generic function and uses method dispatch to avoid conflicts with `graphics:layout()` (fixes #464).
 
-OTHER CHANGES:
+## OTHER CHANGES:
 
 * Upgraded to plotly.js v1.14.1 -- https://github.com/plotly/plotly.js/releases/tag/v1.14.1
 

R/plotly_build.R

@@ -95,7 +95,9 @@ plotly_build.plotly <- function(p) {
     # Fortunately, variable mappings don't make much sense with one observation,
     # and that is the whole point of "recovering" the built data here, so we just ignore
     # cases with one row
-    isVar <- attrLengths > 1 & attrLengths == nobs & !vapply(trace, is.matrix, logical(1))
+    isVar <- (attrLengths > 1 & attrLengths == nobs) & 
+      !vapply(trace, is.matrix, logical(1)) &
+      !vapply(trace, is.bare.list, logical(1))
     builtData <- data.frame(trace[isVar], stringsAsFactors = FALSE)
 
     if (NROW(builtData) > 0) {
@@ -181,7 +183,11 @@ plotly_build.plotly <- function(p) {
       retrace.first = inherits(x, "plotly_polygon")
     )
     for (i in x$.plotlyVariableMapping) {
-      x[[i]] <- structure(uniq(d[[i]]), class = oldClass(x[[i]]))
+      # try to reduce the amount of data we have to send for non-positional scales
+      x[[i]] <- structure(
+        if (i %in% npscales()) uniq(d[[i]]) else d[[i]], 
+        class = oldClass(x[[i]])
+      )
     }
     x
   })

R/utils.R

@@ -10,6 +10,10 @@ is.colorbar <- function(tr) {
   inherits(tr, "plotly_colorbar")
 }
 
+is.bare.list <- function(x) {
+  is.list(x) && !is.data.frame(x)
+}
+
 "%||%" <- function(x, y) {
   if (length(x) > 0 || is_blank(x)) x else y
 }