Merge pull request #1382 from ropensci/colorbar-hoverinfo

cpsievert · web-flow · commit 288c86e1c20f · 2018-11-01T11:46:44.000-05:00
use hoverinfo skip instead of none for invisible ggplotly() colorbar trace, closes #1381
diff --git a/R/ggplotly.R b/R/ggplotly.R
@@ -1300,7 +1300,7 @@ gdef2trace <- function(gdef, theme, gglayout) {
       type = "scatter",
       mode = "markers",
       opacity = 0,
-      hoverinfo = "none",
+      hoverinfo = "skip",
       showlegend = FALSE,
       # do everything on a 0-1 scale
       marker = list(
diff --git a/tests/testthat/test-ggplot-sf.R b/tests/testthat/test-ggplot-sf.R
@@ -54,7 +54,7 @@ test_that("geom_sf() polygons with fill/text.", {
   # one trace for every fillcolor, one for graticule, one for colorbar
   expect_length(l$data, length(unique(nc$AREA)) + 2)
   expect_true(
-    all(unlist(lapply(l$data, "[[", "hoverinfo")) %in% c("none", "text"))
+    all(unlist(lapply(l$data, "[[", "hoverinfo")) %in% c("skip", "none", "text"))
   )
   # graticule styling should inherit from panel.grid.major
   expect_equivalent(

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ test_that("geom_sf() polygons with fill/text.", {`
`54`	`54`	`# one trace for every fillcolor, one for graticule, one for colorbar`
`55`	`55`	`expect_length(l$data, length(unique(nc$AREA)) + 2)`
`56`	`56`	`expect_true(`
`57`		`- all(unlist(lapply(l$data, "[[", "hoverinfo")) %in% c("none", "text"))`
	`57`	`+ all(unlist(lapply(l$data, "[[", "hoverinfo")) %in% c("skip", "none", "text"))`
`58`	`58`	`)`
`59`	`59`	`# graticule styling should inherit from panel.grid.major`
`60`	`60`	`expect_equivalent(`