Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

[dash-table] Improve dropdown props typing #339

Closed
Marc-Andre-Rivet opened this issue Jan 21, 2019 · 1 comment
Closed

[dash-table] Improve dropdown props typing #339

Marc-Andre-Rivet opened this issue Jan 21, 2019 · 1 comment
Labels
dash-type-maintenance Technical debt, dependency management, additional testing, etc.

Comments

@Marc-Andre-Rivet
Copy link
Contributor

dropdown_properties, column_static_dropdown, column_conditional_dropdowns are very loosely typed at the moment -- that typing can be improved, amongst other things by using PropTypes.objectOf which defined the structure of the object's properties but allows any property name.

This relates to #156, #143.

@Marc-Andre-Rivet Marc-Andre-Rivet added the dash-type-maintenance Technical debt, dependency management, additional testing, etc. label Jan 21, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet changed the title Improve dropdown props typing [dash-table] Improve dropdown props typing Mar 25, 2019
@alexcjohnson
Copy link
Collaborator

The new structure as of #446 is pretty complete in its typing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash-type-maintenance Technical debt, dependency management, additional testing, etc.
Projects
None yet
Development

No branches or pull requests

2 participants