Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Commit 7812cba

Browse files
authored
Merge pull request #108 from plotly/remove-authentication
Remove `Authentication` component.
2 parents f45d2c9 + 2071021 commit 7812cba

File tree

11 files changed

+3430
-4343
lines changed

11 files changed

+3430
-4343
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
All notable changes to this project will be documented in this file.
33
This project adheres to [Semantic Versioning](http://semver.org/).
44

5+
## [UNRELEASED] - 2018-12-17
6+
### Removed
7+
- Unused login api and Authentication component [#108](https://github.com/plotly/dash-renderer/pull/108)
8+
59
## [0.16.1] - 2018-12-14
610
### Fixed
711
- Added `key` to rendered components, fixing [#379](https://github.com/plotly/dash-core-components/issues/379)

dash_renderer/dash_renderer.dev.js

Lines changed: 3402 additions & 4059 deletions
Large diffs are not rendered by default.

dash_renderer/dash_renderer.dev.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dash_renderer/dash_renderer.min.js

Lines changed: 4 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dash_renderer/dash_renderer.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/AppContainer.react.js

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,37 @@
11
import {connect} from 'react-redux';
22
import React from 'react';
3-
import Authentication from './Authentication.react';
3+
import PropTypes from 'prop-types';
44
import APIController from './APIController.react';
55
import DocumentTitle from './components/core/DocumentTitle.react';
66
import Loading from './components/core/Loading.react';
77
import Toolbar from './components/core/Toolbar.react';
88
import Reloader from './components/core/Reloader.react';
9+
import {readConfig} from './actions';
910

10-
function UnconnectedAppContainer() {
11-
return (
12-
<Authentication>
11+
class UnconnectedAppContainer extends React.Component {
12+
13+
componentWillMount() {
14+
const {dispatch} = this.props;
15+
dispatch(readConfig())
16+
}
17+
18+
render() {
19+
return (
1320
<div>
1421
<Toolbar />
1522
<APIController />
1623
<DocumentTitle />
1724
<Loading />
1825
<Reloader />
1926
</div>
20-
</Authentication>
21-
);
27+
);
28+
}
2229
}
2330

31+
UnconnectedAppContainer.propTypes = {
32+
dispatch: PropTypes.func,
33+
};
34+
2435
const AppContainer = connect(
2536
state => ({
2637
history: state.history,

src/Authentication.react.js

Lines changed: 0 additions & 253 deletions
This file was deleted.

src/actions/api.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,6 @@ export function getDependencies() {
9191
return apiThunk('_dash-dependencies', 'GET', 'dependenciesRequest');
9292
}
9393

94-
export function login(oauth_token) {
95-
return apiThunk('_dash-login', 'POST', 'loginRequest', '', '', {
96-
Authorization: `Bearer ${oauth_token}`,
97-
});
98-
}
99-
10094
export function getReloadHash() {
10195
return apiThunk('_reload-hash', 'GET', 'reloadRequest');
10296
}

src/components/core/Reloader.react.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ class Reloader extends React.Component {
5151
) {
5252
// Look if it was a css file.
5353
let was_css = false;
54+
// eslint-disable-next-line prefer-const
5455
for (let a of reloadRequest.content.files) {
5556
if (a.is_css) {
5657
was_css = true;

src/reducers/api.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,4 @@ function createApiReducer(store) {
3636

3737
export const dependenciesRequest = createApiReducer('dependenciesRequest');
3838
export const layoutRequest = createApiReducer('layoutRequest');
39-
export const loginRequest = createApiReducer('loginRequest');
4039
export const reloadRequest = createApiReducer('reloadRequest');

src/reducers/reducer.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ const reducer = combineReducers({
1919
config,
2020
dependenciesRequest: API.dependenciesRequest,
2121
layoutRequest: API.layoutRequest,
22-
loginRequest: API.loginRequest,
2322
reloadRequest: API.reloadRequest,
2423
history,
2524
});

0 commit comments

Comments
 (0)